From: "Andreas Färber" <afaerber@suse.de>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: "Anthony Liguori" <aliguori@us.ibm.com>,
"Stefano Stabellini" <stefano.stabellini@eu.citrix.com>,
qemu-devel <qemu-devel@nongnu.org>,
"Julien Grall" <julien.grall@citrix.com>,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Avi Kivity" <avi@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] pc: Drop practically unused BOCHS BIOS debug ports
Date: Tue, 11 Sep 2012 17:11:39 +0200 [thread overview]
Message-ID: <504F54AB.6000406@suse.de> (raw)
In-Reply-To: <504F530B.3030106@siemens.com>
Am 11.09.2012 17:04, schrieb Jan Kiszka:
> On 2012-09-11 16:48, Andreas Färber wrote:
>> Am 11.09.2012 16:38, schrieb Jan Kiszka:
>>> We have debugcon these days to listen on those ports that receive debug
>>> messages. Also drop the others that have no effect anymore.
>>>
>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> This looks pretty identical to Hervé's "pc: remove DEBUG_BIOS define and
>> QEMU exit I/O ports", doesn't it? The discussion there concluded that
>> compatibility needs to be provided for older machines.
>
> I'm not removing any behaviour that can be achieved _without_
> additionally patching QEMU. I'm just removing practically dead debug
> code, leaving in the bits that do have effects.
Didn't want to argue about that, just pointing you to the discussion
thread that you have snipped above. It was Anthony's request. ;)
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-09-11 15:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-11 14:38 [Qemu-devel] [PATCH] pc: Drop practically unused BOCHS BIOS debug ports Jan Kiszka
2012-09-11 14:48 ` Andreas Färber
2012-09-11 15:04 ` Jan Kiszka
2012-09-11 15:11 ` Andreas Färber [this message]
2012-09-11 15:27 ` Jan Kiszka
2012-09-11 15:06 ` Anthony Liguori
2012-09-17 18:25 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504F54AB.6000406@suse.de \
--to=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=hpoussin@reactos.org \
--cc=jan.kiszka@siemens.com \
--cc=julien.grall@citrix.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).