From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44743) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TBS7w-0004g8-Oo for qemu-devel@nongnu.org; Tue, 11 Sep 2012 11:11:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TBS7r-0002Uf-UJ for qemu-devel@nongnu.org; Tue, 11 Sep 2012 11:11:48 -0400 Received: from cantor2.suse.de ([195.135.220.15]:59834 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TBS7r-0002Ua-Nq for qemu-devel@nongnu.org; Tue, 11 Sep 2012 11:11:43 -0400 Message-ID: <504F54AB.6000406@suse.de> Date: Tue, 11 Sep 2012 17:11:39 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <504F4CE1.7020405@siemens.com> <504F4F38.3040401@suse.de> <504F530B.3030106@siemens.com> In-Reply-To: <504F530B.3030106@siemens.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] pc: Drop practically unused BOCHS BIOS debug ports List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Anthony Liguori , Stefano Stabellini , qemu-devel , Julien Grall , =?ISO-8859-1?Q?Herv=E9_Poussineau?= , Avi Kivity , Gerd Hoffmann Am 11.09.2012 17:04, schrieb Jan Kiszka: > On 2012-09-11 16:48, Andreas F=E4rber wrote: >> Am 11.09.2012 16:38, schrieb Jan Kiszka: >>> We have debugcon these days to listen on those ports that receive deb= ug >>> messages. Also drop the others that have no effect anymore. >>> >>> Signed-off-by: Jan Kiszka >> >> This looks pretty identical to Herv=E9's "pc: remove DEBUG_BIOS define= and >> QEMU exit I/O ports", doesn't it? The discussion there concluded that >> compatibility needs to be provided for older machines. >=20 > I'm not removing any behaviour that can be achieved _without_ > additionally patching QEMU. I'm just removing practically dead debug > code, leaving in the bits that do have effects. Didn't want to argue about that, just pointing you to the discussion thread that you have snipped above. It was Anthony's request. ;) Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg