Re: [Qemu-devel] [PATCH] pc: Drop practically unused BOCHS BIOS debug ports

[Jan Kiszka <jan.kiszka@siemens.com>]

On 2012-09-11 17:11, Andreas Färber wrote:
> Am 11.09.2012 17:04, schrieb Jan Kiszka:
>> On 2012-09-11 16:48, Andreas Färber wrote:
>>> Am 11.09.2012 16:38, schrieb Jan Kiszka:
>>>> We have debugcon these days to listen on those ports that receive debug
>>>> messages. Also drop the others that have no effect anymore.
>>>>
>>>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>>>
>>> This looks pretty identical to Hervé's "pc: remove DEBUG_BIOS define and
>>> QEMU exit I/O ports", doesn't it? The discussion there concluded that
>>> compatibility needs to be provided for older machines.
>>
>> I'm not removing any behaviour that can be achieved _without_
>> additionally patching QEMU. I'm just removing practically dead debug
>> code, leaving in the bits that do have effects.
> 
> Didn't want to argue about that, just pointing you to the discussion
> thread that you have snipped above. It was Anthony's request. ;)

The 2nd patch cited did more than what my patch does by making those
ports optional (and apparently default off) that do have effect.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux