From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49598) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TBT9Z-0000Vn-LC for qemu-devel@nongnu.org; Tue, 11 Sep 2012 12:17:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TBT9Y-0008Py-L7 for qemu-devel@nongnu.org; Tue, 11 Sep 2012 12:17:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33270) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TBT9Y-0008Po-C1 for qemu-devel@nongnu.org; Tue, 11 Sep 2012 12:17:32 -0400 Message-ID: <504F6416.1070001@redhat.com> Date: Tue, 11 Sep 2012 18:17:26 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1343127865-16608-1-git-send-email-pbonzini@redhat.com> <1343127865-16608-25-git-send-email-pbonzini@redhat.com> <504F513F.2040006@redhat.com> In-Reply-To: <504F513F.2040006@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 24/47] block: introduce new dirty bitmap functionality List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: jcody@redhat.com, eblake@redhat.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com Il 11/09/2012 16:57, Kevin Wolf ha scritto: >> > Assert that write_compressed is never used with the dirty bitmap. >> > Setting the bits early is wrong, because a coroutine might concurrently >> > examine them and copy incomplete data from the source. >> > >> > Signed-off-by: Paolo Bonzini > Looks good, but I think it should be documented at least that > bdrv_get_next_dirty() hangs when it's called and there is no dirty block. Since bdrv_get_next_dirty disappears soon, I'll just add an assertion. Paolo