From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41426) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TBWX9-0007N2-6h for qemu-devel@nongnu.org; Tue, 11 Sep 2012 15:54:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TBWX5-0001D1-8s for qemu-devel@nongnu.org; Tue, 11 Sep 2012 15:54:07 -0400 Received: from hub021-nj-6.exch021.serverdata.net ([206.225.164.222]:1026) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TBWX5-0001Cx-5q for qemu-devel@nongnu.org; Tue, 11 Sep 2012 15:54:03 -0400 Message-ID: <504F96DA.2040001@CloudSwitch.Com> Date: Tue, 11 Sep 2012 15:54:02 -0400 From: Don Slutz MIME-Version: 1.0 References: <1346961939-32338-1-git-send-email-ehabkost@redhat.com> <1346961939-32338-6-git-send-email-ehabkost@redhat.com> In-Reply-To: <1346961939-32338-6-git-send-email-ehabkost@redhat.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 5/5] i386: -cpu help: remove reference to specific CPUID leaves/registers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Igor Mammedov , qemu-devel@nongnu.org, Anthony Liguori , =?ISO-8859-1?Q?Andreas_F=E4rber?= On 09/06/12 16:05, Eduardo Habkost wrote: > The -cpu configuration interface is based on a list of feature names or > properties, on a single namespace, so there's no need to mention on > which CPUID leaf/register each flag is located. > > Signed-off-by: Eduardo Habkost > --- > target-i386/cpu.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > index 4b65b33..ac12139 100644 > --- a/target-i386/cpu.c > +++ b/target-i386/cpu.c > @@ -1312,13 +1312,13 @@ void x86_cpu_list(FILE *f, fprintf_function cpu_fprintf) > } > (*cpu_fprintf)(f, "\nRecognized CPUID flags:\n"); > listflags(buf, sizeof(buf), (uint32_t)~0, feature_name, 1); > - (*cpu_fprintf)(f, " f_edx: %s\n", buf); > + (*cpu_fprintf)(f, " %s\n", buf); > listflags(buf, sizeof(buf), (uint32_t)~0, ext_feature_name, 1); > - (*cpu_fprintf)(f, " f_ecx: %s\n", buf); > + (*cpu_fprintf)(f, " %s\n", buf); > listflags(buf, sizeof(buf), (uint32_t)~0, ext2_feature_name, 1); > - (*cpu_fprintf)(f, " extf_edx: %s\n", buf); > + (*cpu_fprintf)(f, " %s\n", buf); > listflags(buf, sizeof(buf), (uint32_t)~0, ext3_feature_name, 1); > - (*cpu_fprintf)(f, " extf_ecx: %s\n", buf); > + (*cpu_fprintf)(f, " %s\n", buf); > } > > CpuDefinitionInfoList *arch_query_cpu_definitions(Error **errp) Reviewed-by: Don Slutz