From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36330) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TBYyZ-00026w-Bj for qemu-devel@nongnu.org; Tue, 11 Sep 2012 18:30:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TBYyW-0004Xk-Rz for qemu-devel@nongnu.org; Tue, 11 Sep 2012 18:30:35 -0400 Received: from mail-qc0-f173.google.com ([209.85.216.173]:52930) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TBYyW-0004Xa-On for qemu-devel@nongnu.org; Tue, 11 Sep 2012 18:30:32 -0400 Received: by qcab12 with SMTP id b12so662626qca.4 for ; Tue, 11 Sep 2012 15:30:32 -0700 (PDT) Sender: Richard Henderson Message-ID: <504FBB85.80803@twiddle.net> Date: Tue, 11 Sep 2012 15:30:29 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1347236407-10465-1-git-send-email-crwulff@gmail.com> <1347236407-10465-2-git-send-email-crwulff@gmail.com> <20120911213443.GA6791@ohm.aurel32.net> In-Reply-To: <20120911213443.GA6791@ohm.aurel32.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/9] NiosII: Add support for the Altera NiosII soft-core CPU. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: crwulff@gmail.com, qemu-devel@nongnu.org On 09/11/2012 02:34 PM, Aurelien Jarno wrote: > Minor nitpick: it's better to write: > > tcg_gen_add_tl(addr, addr, dc->cpu_R[instr->a]); > > as the code generator on non-RISC hosts usually generate a slightly tiny > better code. You know... we already swap operands for constants. It would be trivial have tcg_constant_folding swap for matching operands at the same time. r~