From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53758) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TBZK4-0004Gy-22 for qemu-devel@nongnu.org; Tue, 11 Sep 2012 18:52:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TBZK3-0002VW-2g for qemu-devel@nongnu.org; Tue, 11 Sep 2012 18:52:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52823) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TBZK2-0002VI-QI for qemu-devel@nongnu.org; Tue, 11 Sep 2012 18:52:47 -0400 Message-ID: <504FC0B1.7080903@redhat.com> Date: Tue, 11 Sep 2012 16:52:33 -0600 From: Eric Blake MIME-Version: 1.0 References: <1347265586-17698-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1347265586-17698-3-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig44EF2F82A682D2657D6D4A80" Subject: Re: [Qemu-devel] [PATCH V2 2/6] libqblock type and structure defines List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanha@gmail.com, qemu-devel@nongnu.org, pbonzini@redhat.com, Wenchao Xia This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig44EF2F82A682D2657D6D4A80 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/11/2012 02:31 PM, Blue Swirl wrote: > On Mon, Sep 10, 2012 at 8:26 AM, Wenchao Xia wrote: >> This patch contains type and defines used in APIs, one file for publ= ic usage >> by user, one for libqblock internal usage. >> >> + >> +#if __GNUC__ >=3D 4 >=20 > #if defined(__GNUC__) && __GNUC__ ... Seriously? We require a C99-compliant compiler, which is required to treat the more compact version identically (all undefined names evaluate to 0 in the preprocessor), and HACKING doesn't mandate that we spell out a defined-ness check first. Okay, so configure adds -Wundef to the set of CFLAGS, but I fail to see why we want -Wundef (that's an anachronistic warning, only there to help you if you are writing code portable to K&R). --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig44EF2F82A682D2657D6D4A80 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQT8C0AAoJEKeha0olJ0Nq/bkH/jgFy2s0hjJFiXhGJetpdPq/ JQ6S9hjvxEolWv2Gqz2DqPeTKKwUCA3FP2vhddqvLmYJnFXVxL8hRTs3PxM+gW1/ t+ssMoyhRkaOBUxv6FJmSWVFA+dLk1i4UbB9S8i+NgCbBt/8vV91ckNZ0Cjna3Im jaUDJmUf7pfE67mNaIraCadHlpu+rTjBewf94j2yY+F6yQoUjn2PMsGaaPZQcfjb zWguqZQi7PKWZlMgdPKAXzBoX8NLhDVCnat3AZ9Tv0yBg15s1jxOth7QCgEbAtQQ vsh2NkxwTlG30uSTsx0XlYnw0YV/MGzypSP2pvToFOBCInDRFBAfErHYJmhf0Xg= =n/x/ -----END PGP SIGNATURE----- --------------enig44EF2F82A682D2657D6D4A80--