qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Wilfred Mallawa <wilfred.mallawa@wdc.com>
To: "richard.henderson@linaro.org" <richard.henderson@linaro.org>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: "stefanha@gmail.com" <stefanha@gmail.com>,
	"pavel.dovgaluk@ispras.ru" <pavel.dovgaluk@ispras.ru>
Subject: Re: [PATCH for-7.2] replay: Fix declaration of replay_read_next_clock
Date: Tue, 29 Nov 2022 07:03:56 +0000	[thread overview]
Message-ID: <504aa97b99bd9d7d471bbef002974b4ee4c3c947.camel@wdc.com> (raw)
In-Reply-To: <20221129010547.284051-1-richard.henderson@linaro.org>

On Mon, 2022-11-28 at 17:05 -0800, Richard Henderson wrote:
> Fixes the build with gcc 13:
> 
> replay/replay-time.c:34:6: error: conflicting types for  \
>   'replay_read_next_clock' due to enum/integer mismatch; \
>   have 'void(ReplayClockKind)' [-Werror=enum-int-mismatch]
>    34 | void replay_read_next_clock(ReplayClockKind kind)
>       |      ^~~~~~~~~~~~~~~~~~~~~~
> In file included from ../qemu/replay/replay-time.c:14:
> replay/replay-internal.h:139:6: note: previous declaration of \
>   'replay_read_next_clock' with type 'void(unsigned int)'
>   139 | void replay_read_next_clock(unsigned int kind);
>       |      ^~~~~~~~~~~~~~~~~~~~~~
> 
> Fixes: 8eda206e090 ("replay: recording and replaying clock ticks")
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  replay/replay-internal.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
Reviewed-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
> diff --git a/replay/replay-internal.h b/replay/replay-internal.h
> index 89e377be90..b6836354ac 100644
> --- a/replay/replay-internal.h
> +++ b/replay/replay-internal.h
> @@ -136,7 +136,7 @@ bool replay_next_event_is(int event);
>  /*! Reads next clock value from the file.
>      If clock kind read from the file is different from the
> parameter,
>      the value is not used. */
> -void replay_read_next_clock(unsigned int kind);
> +void replay_read_next_clock(ReplayClockKind kind);
>  
>  /* Asynchronous events queue */
>  


  parent reply	other threads:[~2022-11-29  7:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-29  1:05 [PATCH for-7.2] replay: Fix declaration of replay_read_next_clock Richard Henderson
2022-11-29  6:55 ` Pavel Dovgalyuk
2022-11-29  7:03 ` Wilfred Mallawa [this message]
2022-11-29  7:39 ` Philippe Mathieu-Daudé
2022-11-29 16:13   ` Stefan Hajnoczi
2022-11-29 17:44     ` Philippe Mathieu-Daudé
2022-11-29 19:08 ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=504aa97b99bd9d7d471bbef002974b4ee4c3c947.camel@wdc.com \
    --to=wilfred.mallawa@wdc.com \
    --cc=pavel.dovgaluk@ispras.ru \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).