* [Qemu-devel] [PATCH] configure: usbredir fixes
@ 2012-09-11 18:57 Aurelien Jarno
2012-09-12 5:47 ` Michael Tokarev
2012-09-12 6:10 ` Gerd Hoffmann
0 siblings, 2 replies; 3+ messages in thread
From: Aurelien Jarno @ 2012-09-11 18:57 UTC (permalink / raw)
To: qemu-devel; +Cc: Michael Tokarev, Gerd Hoffmann, Aurelien Jarno
usbredir is only used by system emulation, so add the libraries to
libs_softmmu instead of LIBS.
Cc: Michael Tokarev <mjt@tls.msk.ru>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 7656c32..cf2621a 100755
--- a/configure
+++ b/configure
@@ -2763,7 +2763,7 @@ if test "$usb_redir" != "no" ; then
usb_redir_cflags=$($pkg_config --cflags libusbredirparser 2>/dev/null)
usb_redir_libs=$($pkg_config --libs libusbredirparser 2>/dev/null)
QEMU_CFLAGS="$QEMU_CFLAGS $usb_redir_cflags"
- LIBS="$LIBS $usb_redir_libs"
+ libs_softmmu="$LIBS $usb_redir_libs"
else
if test "$usb_redir" = "yes"; then
feature_not_found "usb-redir"
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] configure: usbredir fixes
2012-09-11 18:57 [Qemu-devel] [PATCH] configure: usbredir fixes Aurelien Jarno
@ 2012-09-12 5:47 ` Michael Tokarev
2012-09-12 6:10 ` Gerd Hoffmann
1 sibling, 0 replies; 3+ messages in thread
From: Michael Tokarev @ 2012-09-12 5:47 UTC (permalink / raw)
To: Aurelien Jarno; +Cc: qemu-devel, Gerd Hoffmann
On 11.09.2012 22:57, Aurelien Jarno wrote:
> usbredir is only used by system emulation, so add the libraries to
> libs_softmmu instead of LIBS.
Fwiw, original code breaks user-static build - not it only
tries to link with unused library but also some distros
does not package/provide static (.a) library for
libusbredirparser (I dunno if it is a general issue).
This patch fixes that. It has been in Debian as a bugfix
since the time usbredir were introduced.
> Cc: Michael Tokarev <mjt@tls.msk.ru>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 7656c32..cf2621a 100755
> --- a/configure
> +++ b/configure
> @@ -2763,7 +2763,7 @@ if test "$usb_redir" != "no" ; then
> usb_redir_cflags=$($pkg_config --cflags libusbredirparser 2>/dev/null)
> usb_redir_libs=$($pkg_config --libs libusbredirparser 2>/dev/null)
> QEMU_CFLAGS="$QEMU_CFLAGS $usb_redir_cflags"
> - LIBS="$LIBS $usb_redir_libs"
> + libs_softmmu="$LIBS $usb_redir_libs"
> else
> if test "$usb_redir" = "yes"; then
> feature_not_found "usb-redir"
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] configure: usbredir fixes
2012-09-11 18:57 [Qemu-devel] [PATCH] configure: usbredir fixes Aurelien Jarno
2012-09-12 5:47 ` Michael Tokarev
@ 2012-09-12 6:10 ` Gerd Hoffmann
1 sibling, 0 replies; 3+ messages in thread
From: Gerd Hoffmann @ 2012-09-12 6:10 UTC (permalink / raw)
To: Aurelien Jarno; +Cc: Michael Tokarev, qemu-devel
On 09/11/12 20:57, Aurelien Jarno wrote:
> usbredir is only used by system emulation, so add the libraries to
> libs_softmmu instead of LIBS.
Patch added to usb patch queue.
thanks,
Gerd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-09-12 6:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-11 18:57 [Qemu-devel] [PATCH] configure: usbredir fixes Aurelien Jarno
2012-09-12 5:47 ` Michael Tokarev
2012-09-12 6:10 ` Gerd Hoffmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).