From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:33730)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1TBobk-0006wK-G9
	for qemu-devel@nongnu.org; Wed, 12 Sep 2012 11:12:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1TBobe-0000u7-Hk
	for qemu-devel@nongnu.org; Wed, 12 Sep 2012 11:12:04 -0400
Received: from mail-qa0-f52.google.com ([209.85.216.52]:46921)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1TBobe-0000u0-DU
	for qemu-devel@nongnu.org; Wed, 12 Sep 2012 11:11:58 -0400
Received: by qabg14 with SMTP id g14so1141734qab.4
	for <qemu-devel@nongnu.org>; Wed, 12 Sep 2012 08:11:58 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <5050A63A.7070707@twiddle.net>
Date: Wed, 12 Sep 2012 08:11:54 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1347224784-19472-1-git-send-email-rth@twiddle.net>
	<1347224784-19472-6-git-send-email-rth@twiddle.net>
	<50508D38.1050101@suse.de>
In-Reply-To: <50508D38.1050101@suse.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 005/126] target-s390: Fix gdbstub
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-devel@nongnu.org

On 09/12/2012 06:25 AM, Alexander Graf wrote:
>> +    case S390_PSWM_REGNUM:
>> +        env->psw.mask = tmpl;
>> +        env->cc_op = (tmpl >> 13) & 3;
> 
> Are you sure this is correct? I thought gdbstub would just ignore the cc bits.

Well... no it won't ignore the cc bits.  But it would appear that I've got
them at the wrong location.  From gdb/s390-tdep.c:

  if (regnum == tdep->cc_regnum)
    {
      enum register_status status;

      status = regcache_raw_read_unsigned (regcache, S390_PSWM_REGNUM, &val);
      if (status == REG_VALID)
        {
          if (register_size (gdbarch, S390_PSWA_REGNUM) == 4)
            val = (val >> 12) & 3;
          else
            val = (val >> 44) & 3;
          store_unsigned_integer (buf, regsize, byte_order, val);
        }
      return status;
    }


r~