From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52624) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TC9PF-00012r-LR for qemu-devel@nongnu.org; Thu, 13 Sep 2012 09:24:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TC9PA-0002LX-AK for qemu-devel@nongnu.org; Thu, 13 Sep 2012 09:24:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59363) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TC9PA-0002Kz-2f for qemu-devel@nongnu.org; Thu, 13 Sep 2012 09:24:28 -0400 Message-ID: <5051DE85.3040908@redhat.com> Date: Thu, 13 Sep 2012 15:24:21 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1343127865-16608-1-git-send-email-pbonzini@redhat.com> <1343127865-16608-29-git-send-email-pbonzini@redhat.com> <5051DC6A.6040008@redhat.com> In-Reply-To: <5051DC6A.6040008@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 28/47] qmp: add drive-mirror command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: jcody@redhat.com, eblake@redhat.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com Il 13/09/2012 15:15, Kevin Wolf ha scritto: >> > + flags = bs->open_flags | BDRV_O_RDWR; > Do we take care to make the image read-only again after completion? Not at the file-descriptor level, but bs->read_only is indeed restored to "true" via bdrv_swap. Doing it on the file descriptor is possible with Jeff's bdrv_reopen patches. Paolo