From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50544) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TC9RY-00025z-9l for qemu-devel@nongnu.org; Thu, 13 Sep 2012 09:27:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TC9RS-0003ok-Hs for qemu-devel@nongnu.org; Thu, 13 Sep 2012 09:26:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53373) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TC9RS-0003od-9q for qemu-devel@nongnu.org; Thu, 13 Sep 2012 09:26:50 -0400 Message-ID: <5051DF0D.2030602@redhat.com> Date: Thu, 13 Sep 2012 15:26:37 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1343127865-16608-1-git-send-email-pbonzini@redhat.com> <1343127865-16608-29-git-send-email-pbonzini@redhat.com> <5051DC6A.6040008@redhat.com> <5051DE85.3040908@redhat.com> In-Reply-To: <5051DE85.3040908@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 28/47] qmp: add drive-mirror command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: jcody@redhat.com, eblake@redhat.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com Am 13.09.2012 15:24, schrieb Paolo Bonzini: > Il 13/09/2012 15:15, Kevin Wolf ha scritto: >>>> + flags = bs->open_flags | BDRV_O_RDWR; >> Do we take care to make the image read-only again after completion? > > Not at the file-descriptor level, but bs->read_only is indeed restored > to "true" via bdrv_swap. > > Doing it on the file descriptor is possible with Jeff's bdrv_reopen patches. Ah, right, obviously you can't do it before Jeff's patches are in. But yes, this is what I meant. Kevin