From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34827) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TC9co-0006N8-LA for qemu-devel@nongnu.org; Thu, 13 Sep 2012 09:38:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TC9ci-0007EC-Jo for qemu-devel@nongnu.org; Thu, 13 Sep 2012 09:38:34 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:43296) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TC9ci-0007Dp-Ck for qemu-devel@nongnu.org; Thu, 13 Sep 2012 09:38:28 -0400 Received: by pbbrp12 with SMTP id rp12so4165928pbb.4 for ; Thu, 13 Sep 2012 06:38:26 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <5051E1C9.2020002@redhat.com> Date: Thu, 13 Sep 2012 15:38:17 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1343127865-16608-1-git-send-email-pbonzini@redhat.com> <1343127865-16608-29-git-send-email-pbonzini@redhat.com> <5051DC6A.6040008@redhat.com> <5051DE85.3040908@redhat.com> <5051DF0D.2030602@redhat.com> In-Reply-To: <5051DF0D.2030602@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 28/47] qmp: add drive-mirror command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: jcody@redhat.com, eblake@redhat.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com Il 13/09/2012 15:26, Kevin Wolf ha scritto: >>>>> + flags = bs->open_flags | BDRV_O_RDWR; >>> >> Do we take care to make the image read-only again after completion? >> > >> > Not at the file-descriptor level, but bs->read_only is indeed restored >> > to "true" via bdrv_swap. >> > >> > Doing it on the file descriptor is possible with Jeff's bdrv_reopen patches. > Ah, right, obviously you can't do it before Jeff's patches are in. But > yes, this is what I meant. Still, the guest won't be able to issue writes after switching to the destination, if it couldn't do so before. Paolo