qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: qemu-ppc@nongnu.org, agraf@suse.de, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 03/13] pseries: Use new method to correct reset sequence
Date: Thu, 13 Sep 2012 16:08:22 +0200	[thread overview]
Message-ID: <5051E8D6.6000808@suse.de> (raw)
In-Reply-To: <1347505041-27411-4-git-send-email-david@gibson.dropbear.id.au>

David,

Am 13.09.2012 04:57, schrieb David Gibson:
> A number of things need to occur during reset of the PAPR
> paravirtualized platform in a specific order.  For example, the hash
> table needs to be cleared before the CPUs are reset, so that they
> initialize their register state correctly, and the CPUs need to have
> their main reset called before we set up the entry point state on the
> boot cpu.  We also need to have the main qdev reset happen before the
> creation and installation of the device tree for the new boot, because
> we need the state of the devices settled to correctly construct the
> device tree.
> 
> We currently do the pseries once-per-reset initializations done from a
> reset handler.  However we can't adequately control when this handler
> is called during the reset - in particular we can't guarantee it
> happens after all the qdev resets (since qdevs might be registered
> after the machine init function has executed).
> 
> This patch uses the new QEMUMachine reset method to to fix this
> problem, ensuring the various order dependent reset steps happen in
> the correct order.
> 
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

I'm pretty sure I already added

Reviewed-by: Andreas Färber <afaerber@suse.de>

in another thread. Please don't constantly regroup your patches or at
least carry over the tags.

Thanks,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

  reply	other threads:[~2012-09-13 14:08 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-13  2:57 [Qemu-devel] [0/13] pseries patch queue David Gibson
2012-09-13  2:57 ` [Qemu-devel] [PATCH 01/13] ppc: Make kvm_arch_put_registers() put *all* the registers David Gibson
2012-09-13  2:57 ` [Qemu-devel] [PATCH 02/13] pseries: Fix and cleanup CPU initialization and reset David Gibson
2012-09-13 14:10   ` Andreas Färber
2012-09-13  2:57 ` [Qemu-devel] [PATCH 03/13] pseries: Use new method to correct reset sequence David Gibson
2012-09-13 14:08   ` Andreas Färber [this message]
2012-09-13  2:57 ` [Qemu-devel] [PATCH 04/13] pseries: Add support for new KVM hash table control call David Gibson
2012-09-13  2:57 ` [Qemu-devel] [PATCH 05/13] pseries: Clear TCE and signal state when resetting PAPR VIO devices David Gibson
2012-09-13  2:57 ` [Qemu-devel] [PATCH 06/13] pseries: Reset emulated PCI TCE tables on system reset David Gibson
2012-09-13  2:57 ` [Qemu-devel] [PATCH 07/13] pseries: Fix XICS reset David Gibson
2012-09-13  2:57 ` [Qemu-devel] [PATCH 08/13] pseries: Small cleanup to H_CEDE implementation David Gibson
2012-09-13  2:57 ` [Qemu-devel] [PATCH 09/13] pseries: Remove C bitfields from xics code David Gibson
2012-09-13  2:57 ` [Qemu-devel] [PATCH 10/13] pseries: Remove XICS irq type enum type David Gibson
2012-09-13  2:57 ` [Qemu-devel] [PATCH 11/13] pseries: Remove never used flags field from spapr vio devices David Gibson
2012-09-13  2:57 ` [Qemu-devel] [PATCH 12/13] pseries: Rework implementation of TCE bypass David Gibson
2012-09-13  2:57 ` [Qemu-devel] [PATCH 13/13] pseries: Fix semantics of RTAS int-on, int-off and set-xive functions David Gibson
2012-09-19 12:12 ` [Qemu-devel] [0/13] pseries patch queue Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5051E8D6.6000808@suse.de \
    --to=afaerber@suse.de \
    --cc=agraf@suse.de \
    --cc=david@gibson.dropbear.id.au \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).