From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:45560)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TCBvv-0006fh-76
	for qemu-devel@nongnu.org; Thu, 13 Sep 2012 12:06:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TCBvq-0003w7-Vg
	for qemu-devel@nongnu.org; Thu, 13 Sep 2012 12:06:27 -0400
Received: from mx1.redhat.com ([209.132.183.28]:57430)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TCBvq-0003w0-MZ
	for qemu-devel@nongnu.org; Thu, 13 Sep 2012 12:06:22 -0400
Message-ID: <50520461.6090001@redhat.com>
Date: Thu, 13 Sep 2012 18:05:53 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <cover.1347548248.git.jcody@redhat.com>
	<925addfddafe2c9c0c35a55d3de954ad1d0b0a5f.1347548248.git.jcody@redhat.com>
In-Reply-To: <925addfddafe2c9c0c35a55d3de954ad1d0b0a5f.1347548248.git.jcody@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 09/16] block: raw image file reopen
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jeff Cody <jcody@redhat.com>
Cc: kwolf@redhat.com, supriyak@linux.vnet.ibm.com, eblake@redhat.com, qemu-devel@nongnu.org, stefanha@gmail.com

Il 13/09/2012 17:49, Jeff Cody ha scritto:
> +/* We have nothing to do for raw reopen, stubs just return
> + * success */
> +static int raw_reopen_prepare(BDRVReopenState *state, Error **errp)
> +{
> +    return 0;
> +}
> +
> +static void raw_reopen_commit(BDRVReopenState *state)
> +{
> +    return;
> +}
> +
> +static void raw_reopen_abort(BDRVReopenState *state)
> +{
> +    return;
> +}
> +
> +

Commit and abort are optional, aren't they?

BTW, vdi and vpc should also support reopen.

Paolo