Re: [Qemu-devel] [PATCH v2 09/16] block: raw image file reopen

[Jeff Cody <jcody@redhat.com>]

On 09/13/2012 12:05 PM, Paolo Bonzini wrote:
> Il 13/09/2012 17:49, Jeff Cody ha scritto:
>> +/* We have nothing to do for raw reopen, stubs just return
>> + * success */
>> +static int raw_reopen_prepare(BDRVReopenState *state, Error **errp)
>> +{
>> +    return 0;
>> +}
>> +
>> +static void raw_reopen_commit(BDRVReopenState *state)
>> +{
>> +    return;
>> +}
>> +
>> +static void raw_reopen_abort(BDRVReopenState *state)
>> +{
>> +    return;
>> +}
>> +
>> +
> 
> Commit and abort are optional, aren't they?
> 
> BTW, vdi and vpc should also support reopen.
> 
> Paolo
> 

The commit and abort block driver handlers are indeed optional, prepare
is the only required one.  I kept the stubs for them for completeness,
however (I can remove them if that causes heartburn for others).

A quick look at the vdi and vpc block drivers seems to indicate that
both of those can be supported via stubs as well; I'll add them to v3.

Thanks,
Jeff