From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56414) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TCDE9-0003v7-Q6 for qemu-devel@nongnu.org; Thu, 13 Sep 2012 13:29:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TCDE8-0005Vs-JS for qemu-devel@nongnu.org; Thu, 13 Sep 2012 13:29:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38333) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TCDE8-0005Vk-9S for qemu-devel@nongnu.org; Thu, 13 Sep 2012 13:29:20 -0400 Message-ID: <505217E7.2000902@redhat.com> Date: Thu, 13 Sep 2012 11:29:11 -0600 From: Eric Blake MIME-Version: 1.0 References: <60c0aeea2beda33af8409ff05aa8484540913ac5.1347548248.git.jcody@redhat.com> In-Reply-To: <60c0aeea2beda33af8409ff05aa8484540913ac5.1347548248.git.jcody@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig6BC4F0DFCD77BDCBCCFA1C52" Subject: Re: [Qemu-devel] [PATCH v2 07/16] block: move allocating aligned_buf into a helper function in raw_posix.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody Cc: kwolf@redhat.com, pbonzini@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, supriyak@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig6BC4F0DFCD77BDCBCCFA1C52 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/13/2012 09:49 AM, Jeff Cody wrote: > Code motion, to move allocating aligned_buf and setting aligned_buf_siz= e > into a helper function. >=20 > Signed-off-by: Jeff Cody > --- > block/raw-posix.c | 31 ++++++++++++++++++++++--------- > 1 file changed, 22 insertions(+), 9 deletions(-) >=20 > + if ((bdrv_flags & BDRV_O_NOCACHE)) { > + /* > + * Allocate a buffer for read/modify/write cycles. Chose the = size Pre-existing typo, but as long as you are moving it, s/Chose/Choose/ --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig6BC4F0DFCD77BDCBCCFA1C52 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQUhfnAAoJEKeha0olJ0Nq0tIH/1dsV5zcQ6RbdxCm2cqj8LtV AWgLuOuB030iOerTl9p4C0Wm1LT5H3BQsZCpak2tafI/qKGoS+0fyf35hO5dhARm UrSmIPS39bDf8i5mZW8F0D/EA+yGgBFqk0qxJJWsZFjQI9ypFHpfV8wUAPaVPuX5 mRgFU1LEjkLcnodQyjIf2vjE8dRKuP1P8A45Svon7cuOsuwKGGjq37V96p8/8/y2 8EIXwo8XtYjPY4v8O8clmI6nZdoFIXxLMCOwOnk+eMNNg4hdi6q7matdCIGWGBM7 mulfBOUeZRh9wIS7Hk1TNCGYTCXDaDuZIZTXZLvTcmZ23Z2APkjxqPZ54aTa6yQ= =rGVT -----END PGP SIGNATURE----- --------------enig6BC4F0DFCD77BDCBCCFA1C52--