From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35152) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TCQSi-0001MG-3w for qemu-devel@nongnu.org; Fri, 14 Sep 2012 03:37:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TCQSc-0002EF-80 for qemu-devel@nongnu.org; Fri, 14 Sep 2012 03:37:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:13322) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TCQSc-0002E5-04 for qemu-devel@nongnu.org; Fri, 14 Sep 2012 03:37:10 -0400 Message-ID: <5052DE9F.9030609@redhat.com> Date: Fri, 14 Sep 2012 09:37:03 +0200 From: Gerd Hoffmann MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 11/25] q35: Introduce q35 pc based chipset emulator List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Baron Cc: aliguori@us.ibm.com, juzhang@redhat.com, mst@redhat.com, jan.kiszka@siemens.com, qemu-devel@nongnu.org, agraf@suse.de, yamahata@valinux.co.jp, alex.williamson@redhat.com, kevin@koconnor.net, avi@redhat.com, mkletzan@redhat.com, lcapitulino@redhat.com, afaerber@suse.de, armbru@redhat.com On 09/13/12 22:12, Jason Baron wrote: > + if (ram_size >= 0xe0000000) { > + above_4g_mem_size = ram_size - 0xe0000000; > + below_4g_mem_size = 0xe0000000; We should make the hole larger to get more pci i/o address space below 4G, especially as q35 needs a good chunk of it for mmconfig. I think at least 0xc0000000, maybe even 0xb0000000. The later would allow to place mmconfig @ 0xb0000000, one big 512MB pci bar @ 0xc0000000 (think gfx card pass-through) and all the remaining little stuff above 0xe0000000. cheers, Gerd