From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57007) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TCQkj-0001Ph-Vx for qemu-devel@nongnu.org; Fri, 14 Sep 2012 03:55:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TCQkf-0008Uc-CH for qemu-devel@nongnu.org; Fri, 14 Sep 2012 03:55:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60635) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TCQke-0008UR-L5 for qemu-devel@nongnu.org; Fri, 14 Sep 2012 03:55:48 -0400 Message-ID: <5052E2FE.5020908@redhat.com> Date: Fri, 14 Sep 2012 09:55:42 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <01df3140216ac0398bfb3a295c553c42cdf31e5b.1347548248.git.jcody@redhat.com> <5052060A.5010304@redhat.com> <5052DC5C.4080907@redhat.com> <5052E1B2.2080304@redhat.com> <5052E2E2.5040307@redhat.com> In-Reply-To: <5052E2E2.5040307@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 06/16] block: do not parse BDRV_O_CACHE_WB in raw block drivers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: supriyak@linux.vnet.ibm.com, Jeff Cody , eblake@redhat.com, qemu-devel@nongnu.org, stefanha@gmail.com Il 14/09/2012 09:55, Kevin Wolf ha scritto: >> Either we go and touch all the protocols >> > (effectively removing BDRV_O_CACHE_WB from the BlockDriver >> > specification), or treating raw-{posix,win32} specially means we leave >> > bugs everywhere else. > Yes, touch all protocols and fix them. BDRV_O_CACHE_WB should be for > block.c only. That's also fine, of course. Paolo