From: Paolo Bonzini <pbonzini@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>, mdroth@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] directory hierarchy
Date: Fri, 14 Sep 2012 16:03:22 +0200 [thread overview]
Message-ID: <5053392A.3070101@redhat.com> (raw)
In-Reply-To: <20120914104456.4cae13d3@doriath.home>
Il 14/09/2012 15:44, Luiz Capitulino ha scritto:
>> > qapi:
>> > error.c
> error.c isn't tied to a subsystem, it's really "qemu wide". If it
> must reside in dir (ie. it can't be in the top dir), then I'd
> suggest to put it in qmp.
It's either qapi/ or util/. I'd rather avoid util/ as a dumping ground,
and error.c (and propagation) seemed quite central to QAPI. But I can
change.
There is no qmp/. There is qapi/, qobject/ and sysemu/monitor.
Since Anthony mentioned that QOM and QAPI are used together with
QObject, but not tied, putting the JSON stuff in qobject/ made sense
(qga uses it). Renaming qobject/ to qmp/ makes sense, I can do that.
However, it should be clear that qmp/ is for stuff shared by the
emulators and qemu-ga, so qmp.c and qmp-commands.hx do not belong in there.
Paolo
next prev parent reply other threads:[~2012-09-14 14:03 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-14 13:17 [Qemu-devel] directory hierarchy Paolo Bonzini
2012-09-14 13:36 ` Peter Maydell
2012-09-14 13:53 ` Paolo Bonzini
2012-09-16 14:40 ` Anthony Liguori
2012-09-17 7:47 ` Paolo Bonzini
2012-09-14 13:44 ` Luiz Capitulino
2012-09-14 14:03 ` Paolo Bonzini [this message]
2012-09-14 13:47 ` Daniel P. Berrange
2012-09-14 13:57 ` Paolo Bonzini
2012-09-14 13:48 ` Peter Maydell
2012-09-14 13:55 ` Paolo Bonzini
2012-09-14 14:00 ` Peter Maydell
2012-09-14 14:37 ` Stefan Weil
2012-09-14 16:36 ` Paolo Bonzini
2012-09-14 16:09 ` Kevin Wolf
2012-09-14 16:45 ` Paolo Bonzini
2012-09-14 19:51 ` Blue Swirl
2012-09-14 21:28 ` Paolo Bonzini
2012-09-19 12:54 ` Avi Kivity
2012-09-19 19:57 ` Blue Swirl
2012-09-20 11:31 ` Avi Kivity
2012-09-22 13:15 ` Blue Swirl
2012-09-23 8:25 ` Avi Kivity
2012-09-23 16:07 ` Blue Swirl
2012-09-24 9:54 ` Avi Kivity
2012-09-16 14:44 ` Anthony Liguori
2012-09-17 7:52 ` Paolo Bonzini
2012-09-17 13:04 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5053392A.3070101@redhat.com \
--to=pbonzini@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).