From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34312) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TCWUd-0001q3-9U for qemu-devel@nongnu.org; Fri, 14 Sep 2012 10:03:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TCWUX-0002yA-I7 for qemu-devel@nongnu.org; Fri, 14 Sep 2012 10:03:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:63625) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TCWUX-0002y4-9V for qemu-devel@nongnu.org; Fri, 14 Sep 2012 10:03:33 -0400 Message-ID: <5053392A.3070101@redhat.com> Date: Fri, 14 Sep 2012 16:03:22 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <50532E80.5060905@redhat.com> <20120914104456.4cae13d3@doriath.home> In-Reply-To: <20120914104456.4cae13d3@doriath.home> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] directory hierarchy List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: qemu-devel , mdroth@linux.vnet.ibm.com Il 14/09/2012 15:44, Luiz Capitulino ha scritto: >> > qapi: >> > error.c > error.c isn't tied to a subsystem, it's really "qemu wide". If it > must reside in dir (ie. it can't be in the top dir), then I'd > suggest to put it in qmp. It's either qapi/ or util/. I'd rather avoid util/ as a dumping ground, and error.c (and propagation) seemed quite central to QAPI. But I can change. There is no qmp/. There is qapi/, qobject/ and sysemu/monitor. Since Anthony mentioned that QOM and QAPI are used together with QObject, but not tied, putting the JSON stuff in qobject/ made sense (qga uses it). Renaming qobject/ to qmp/ makes sense, I can do that. However, it should be clear that qmp/ is for stuff shared by the emulators and qemu-ga, so qmp.c and qmp-commands.hx do not belong in there. Paolo