From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49195) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TCYLs-00084p-Md for qemu-devel@nongnu.org; Fri, 14 Sep 2012 12:02:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TCYLl-0003sc-FR for qemu-devel@nongnu.org; Fri, 14 Sep 2012 12:02:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44167) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TCYLl-0003sS-7Z for qemu-devel@nongnu.org; Fri, 14 Sep 2012 12:02:37 -0400 Message-ID: <505354DB.20807@redhat.com> Date: Fri, 14 Sep 2012 10:01:31 -0600 From: Eric Blake MIME-Version: 1.0 References: In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigCB871109AAD9F5E01269D2CD" Subject: Re: [Qemu-devel] [PATCH 4/8] qerror: new error for live block commit, QERR_TOP_NOT_FOUND List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody Cc: kwolf@redhat.com, pbonzini@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, supriyak@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigCB871109AAD9F5E01269D2CD Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/14/2012 07:41 AM, Jeff Cody wrote: > Signed-off-by: Jeff Cody > --- > qerror.h | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/qerror.h b/qerror.h > index d0a76a4..7396184 100644 > --- a/qerror.h > +++ b/qerror.h > @@ -219,6 +219,9 @@ void assert_no_error(Error *err); > #define QERR_TOO_MANY_FILES \ > ERROR_CLASS_GENERIC_ERROR, "Too many open files" > =20 > +#define QERR_TOP_NOT_FOUND \ > + ERROR_CLASS_GENERIC_ERROR, "Top image file %s not found" > + Is this patch really still needed, now that the generic error handling is in? Shouldn't you instead be using error_setg() in patch 6/8 for the one place that prints this error message? --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigCB871109AAD9F5E01269D2CD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQU1TcAAoJEKeha0olJ0NqkDEIAIUHc89CrprLp/8Kw4a826IY KcLRmukaFMnkUyrcfatILWReuET3UwqnexROm2jdTci4xe4TjwLhJMWeLwc/xeoY YcB7mU93jAJBwNiYjlQLywMLWpn6PdaiYkIu657j1+gnjzsU1vo6AtC9KTG+urT2 dEnjyTvsqpM9Jq5y0R28V4kYSjof0682mcoeXOJuqLVb4EvdfE3oK3yncCEieZAo KUf7oZ5H784D4BhA88tiV+IKxvBie9mMI6jXqe5nSVCV2NJsy58k7Y536X8HYu0z wbUBQij9ATPzNfzxOUW9BQ35bXvhiuIJ2Y4Ju8/X/f5Iv/kMRrPmupN6/y+hoek= =EAVp -----END PGP SIGNATURE----- --------------enigCB871109AAD9F5E01269D2CD--