From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:33472)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TCtms-0004rj-Kk
	for qemu-devel@nongnu.org; Sat, 15 Sep 2012 10:56:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TCtmr-0000eg-LG
	for qemu-devel@nongnu.org; Sat, 15 Sep 2012 10:56:02 -0400
Received: from cantor2.suse.de ([195.135.220.15]:55347 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TCtmr-0000eY-F8
	for qemu-devel@nongnu.org; Sat, 15 Sep 2012 10:56:01 -0400
Message-ID: <505496FB.3050005@suse.de>
Date: Sat, 15 Sep 2012 16:55:55 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <Nios2-Resend2>
	<1347236407-10465-1-git-send-email-crwulff@gmail.com>
	<1347236407-10465-2-git-send-email-crwulff@gmail.com>
In-Reply-To: <1347236407-10465-2-git-send-email-crwulff@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 1/9] NiosII: Add support for the Altera
 NiosII soft-core CPU.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: crwulff@gmail.com
Cc: qemu-devel@nongnu.org

Am 10.09.2012 02:19, schrieb crwulff@gmail.com:
> From: Chris Wulff <crwulff@gmail.com>
>=20
> Signed-off-by: Chris Wulff <crwulff@gmail.com>
> ---
>  target-nios2/Makefile.objs |    5 +
>  target-nios2/altera_iic.c  |  100 +++
>  target-nios2/cpu-qom.h     |   69 +++
>  target-nios2/cpu.c         |   83 +++
>  target-nios2/cpu.h         |  259 ++++++++
>  target-nios2/exec.h        |   60 ++
>  target-nios2/helper.c      |  291 +++++++++
>  target-nios2/helper.h      |   45 ++
>  target-nios2/instruction.c | 1463 ++++++++++++++++++++++++++++++++++++=
++++++++
>  target-nios2/instruction.h |  290 +++++++++
>  target-nios2/machine.c     |   33 +
>  target-nios2/mmu.c         |  273 +++++++++
>  target-nios2/mmu.h         |   49 ++
>  target-nios2/op_helper.c   |  125 ++++
>  target-nios2/translate.c   |  252 ++++++++
>  15 files changed, 3397 insertions(+)

Some general comments: You're introducing a new target here, so if you
design your API cleanly (using Nios2CPU where possible) you don't really
need a separate cpu-qom.h file in addition to cpu.h, cf. target-or32.

Please prefer passing Nios2CPU as opaque rather than CPUNios2State
(e.g., 3/9; cf. target-arm). Reason is that fields are being moved from
CPUxxxState to CPUState and this will simplify the migration.

Thanks,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg