From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47202) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TD9K1-0004zL-Uo for qemu-devel@nongnu.org; Sun, 16 Sep 2012 03:31:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TD9K0-0001EM-Rg for qemu-devel@nongnu.org; Sun, 16 Sep 2012 03:31:17 -0400 Received: from mout.web.de ([212.227.17.11]:59863) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TD9K0-0001EA-Hb for qemu-devel@nongnu.org; Sun, 16 Sep 2012 03:31:16 -0400 Message-ID: <50558042.6030008@web.de> Date: Sun, 16 Sep 2012 09:31:14 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1347753913-5305-1-git-send-email-vapier@gentoo.org> In-Reply-To: <1347753913-5305-1-git-send-email-vapier@gentoo.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig77E458886ECEC606C198A753" Subject: Re: [Qemu-devel] [PATCH] fix warnings from printf target addresses List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mike Frysinger Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig77E458886ECEC606C198A753 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable On 2012-09-16 02:05, Mike Frysinger wrote: > Current code triggers: > memory.c: In function 'invalid_read': > memory.c:1001: warning: format '%#x' expects type 'unsigned int', > but argument 4 has type 'target_phys_addr_t' > memory.c: In function 'invalid_write': > memory.c:1013: warning: format '%#x' expects type 'unsigned int', > but argument 4 has type 'target_phys_addr_t' This version was never in git. Which QEMU are you patching, a local one? Jan >=20 > Signed-off-by: Mike Frysinger > --- > memory.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git a/memory.c b/memory.c > index 58a242d..7d5f4a3 100644 > --- a/memory.c > +++ b/memory.c > @@ -998,7 +998,8 @@ static uint64_t invalid_read(void *opaque, target_p= hys_addr_t addr, > MemoryRegion *mr =3D opaque; > =20 > if (!mr->warning_printed) { > - fprintf(stderr, "Invalid read from memory region %s at offset = %#x\n", mr->name, addr); > + fprintf(stderr, "Invalid read from memory region %s at offset = %#llx\n", > + mr->name, (unsigned long long)addr); > mr->warning_printed =3D true; > } > return -1U; > @@ -1010,7 +1011,8 @@ static void invalid_write(void *opaque, target_ph= ys_addr_t addr, uint64_t data, > MemoryRegion *mr =3D opaque; > =20 > if (!mr->warning_printed) { > - fprintf(stderr, "Invalid write to memory region %s at offset %= #x\n", mr->name, addr); > + fprintf(stderr, "Invalid write to memory region %s at offset %= #llx\n", > + mr->name, (unsigned long long)addr); > mr->warning_printed =3D true; > } > } >=20 --------------enig77E458886ECEC606C198A753 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iEYEARECAAYFAlBVgEIACgkQitSsb3rl5xQ3aQCgl6zzHQhEBtzI58PSoMcA8aSh F+AAn1C9zx8zzG2W3bSzHO2wE+o///gg =X9Fk -----END PGP SIGNATURE----- --------------enig77E458886ECEC606C198A753--