qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] Compile error
@ 2012-09-16 16:25 Gerhard Wiesinger
  2012-10-10  5:17 ` Gerhard Wiesinger
  0 siblings, 1 reply; 14+ messages in thread
From: Gerhard Wiesinger @ 2012-09-16 16:25 UTC (permalink / raw)
  To: qemu-devel; +Cc: M. Mohan Kumar

Hello,

qemu is currently not compile clean on Fedora 17:

CC fsdev/virtfs-proxy-helper.o
fsdev/virtfs-proxy-helper.c: In function ‘setfsugid’:
fsdev/virtfs-proxy-helper.c:293:13: error: ignoring return value of 
‘setfsgid’, declared with attribute warn_unused_result 
[-Werror=unused-result]
fsdev/virtfs-proxy-helper.c:294:13: error: ignoring return value of 
‘setfsuid’, declared with attribute warn_unused_result 
[-Werror=unused-result]
cc1: all warnings being treated as errors
make: *** [fsdev/virtfs-proxy-helper.o] Error 1

gcc --version
gcc (GCC) 4.7.0 20120507 (Red Hat 4.7.0-5)

Please fix it.

Ciao,
Gerhard

^ permalink raw reply	[flat|nested] 14+ messages in thread
* Re: [Qemu-devel] Do you have a use for a tester of virtio-scsi with CD drives ?
@ 2011-11-02 21:22 Thomas Schmitt
  2011-11-02 22:08 ` Thomas Schmitt
  0 siblings, 1 reply; 14+ messages in thread
From: Thomas Schmitt @ 2011-11-02 21:22 UTC (permalink / raw)
  To: qemu-devel; +Cc: kwolf, stefanha, pbonzini

Hi,

i wrote:
> > So how is this altered to 0x12 in the further course of processing ?

Paolo Bonzini wrote:
> Because you're using an *IDE* (ATAPI) CD-ROM, not SCSI.  See hw/ide/atapi.c.

You convinced me.
But this does not explain yet the difference in behavior of
both groups of IDE DVD-ROMs. Why are those of -drive if=scsi empty ?


> Ok, in your counting I should have written 20 for IDE (0x12 + page number +
> page size) and 22 for SCSI (0x14 + page number + page size).

Why the distinction by transport bus ? Mode page 2Ah is a matter
of the drive alone. MMC is independent of the bus.

MMC-1 prescribes Page Length 0x14 = 20.
This counts the bytes after byte 1 of the mode page.
So the page size is 22 bytes.
The last byte is the LSB of Current Write Speed (MMC-1 table 103).

SPC-1 prescribes to prefix the result of MODE SENSE(10) with 8 bytes
of Mode Parameter Header.
The first two are MSB and LSB of Mode Data Length.
  Mode Data Length = 8 + Page Length = 28 = 0x1c
The total size of the reply should be 30 bytes.
Like
  00 1c xx xx xx xx xx xx 2a 14 xx ... up to 30 bytes ...
 
The history of mode page 2Ah is colorful.
In MMC-2, the mode page has 26 bytes rather than 22.
In MMC-3, the length is variable. At least 32 bytes, with the
number of 4-byte write speed descriptors in bytes 30 and 31.
In MMC-4 to MMC-6 it is only briefly mentioned as legacy feature.

Since all MMC drivers have to be aware of MMC-1 compliant drives,
it is well ok to stay with MMC-1, although DVD drives appear first
in MMC-2.

So i would propose to replace 28 by 30, and set buf[28], buf[29] to 0
in hw/ide/atapi.c , cmd_mode_sense() , case MODE_PAGE_CAPABILITIES

I tried to check whether buf[] is large enough in the callers.
With some fgrepping i finally end up in hw/ide/core.c:ide_init1()
    s->io_buffer_total_len = IDE_DMA_BUF_SECTORS*512 + 4;
    s->io_buffer = qemu_memalign(2048, s->io_buffer_total_len);
So roughly this should be ok ... if qemu_memalign() has the job to
allocate at least s->io_buffer_total_len bytes.

I did not yet find out, why the IDE drive emulation emits a Mode Data
Length of 0x22. With Page Length 0x12 it should have been 0x1a.
8 too many.


Have a nice day :)

Thomas

^ permalink raw reply	[flat|nested] 14+ messages in thread
* [Qemu-devel] compile error
@ 2005-07-06  8:40 황윤성
  2005-07-06  9:22 ` Hetz Ben Hamo
  0 siblings, 1 reply; 14+ messages in thread
From: 황윤성 @ 2005-07-06  8:40 UTC (permalink / raw)
  To: qemu-devel

[-- Attachment #1: Type: TEXT/PLAIN, Size: 2460 bytes --]

make[1]: Entering directory `/home/hys545/qemu/mips-softmmu'
gcc -Wall -O2 -g -fno-strict-aliasing -fomit-frame-pointer -I. -I/home/hys545/qemu/target-mips -I/home/hys545/qemu -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -I/home/hys545/qemu/fpu -I/home/hys545/qemu/slirp -c -o op_helper.o /home/hys545/qemu/target-mips/op_helper.c
/home/hys545/qemu/target-mips/op_helper.c:33: error: conflicting types for 'do_raise_exception_err'
/home/hys545/qemu/target-mips/exec.h:157: error: previous declaration of 'do_raise_exception_err' was here
/home/hys545/qemu/target-mips/op_helper.c:33: error: conflicting types for 'do_raise_exception_err'
/home/hys545/qemu/target-mips/exec.h:157: error: previous declaration of 'do_raise_exception_err' was here
/home/hys545/qemu/target-mips/op_helper.c:45: error: conflicting types for 'do_raise_exception'
/home/hys545/qemu/target-mips/exec.h:159: error: previous declaration of 'do_raise_exception' was here
/home/hys545/qemu/target-mips/op_helper.c:45: error: conflicting types for 'do_raise_exception'
/home/hys545/qemu/target-mips/exec.h:159: error: previous declaration of 'do_raise_exception' was here
/home/hys545/qemu/target-mips/op_helper.c:119: error: conflicting types for 'do_mfc0'
/home/hys545/qemu/target-mips/exec.h:127: error: previous declaration of 'do_mfc0' was here
/home/hys545/qemu/target-mips/op_helper.c:119: error: conflicting types for 'do_mfc0'
/home/hys545/qemu/target-mips/exec.h:127: error: previous declaration of 'do_mfc0' was here
/home/hys545/qemu/target-mips/op_helper.c:268: error: conflicting types for 'do_mtc0'
/home/hys545/qemu/target-mips/exec.h:129: error: previous declaration of 'do_mtc0' was here
/home/hys545/qemu/target-mips/op_helper.c:268: error: conflicting types for 'do_mtc0'
/home/hys545/qemu/target-mips/exec.h:129: error: previous declaration of 'do_mtc0' was here
/home/hys545/qemu/target-mips/op_helper.c:607: error: conflicting types for 'do_pmon'
/home/hys545/qemu/target-mips/exec.h:149: error: previous declaration of 'do_pmon' was here
/home/hys545/qemu/target-mips/op_helper.c:607: error: conflicting types for 'do_pmon'
/home/hys545/qemu/target-mips/exec.h:149: error: previous declaration of 'do_pmon' was here
make[1]: *** [op_helper.o] 오류 1

My step is
cvs update-2005-7-6
./configure
make


-------------------------------------------------
Your Life on the Net
DreamWiz Free Mail @ http://www.dreamwiz.com/


[-- Attachment #2: Type: TEXT/HTML, Size: 6455 bytes --]

<HTML>
<BODY>

<BR>make[1]: Entering directory `/home/hys545/qemu/mips-softmmu'
<BR>gcc -Wall -O2 -g -fno-strict-aliasing -fomit-frame-pointer -I. -I/home/hys545/qemu/target-mips -I/home/hys545/qemu -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -I/home/hys545/qemu/fpu -I/home/hys545/qemu/slirp -c -o op_helper.o /home/hys545/qemu/target-mips/op_helper.c
<BR>/home/hys545/qemu/target-mips/op_helper.c:33: error: conflicting types for 'do_raise_exception_err'
<BR>/home/hys545/qemu/target-mips/exec.h:157: error: previous declaration of 'do_raise_exception_err' was here
<BR>/home/hys545/qemu/target-mips/op_helper.c:33: error: conflicting types for 'do_raise_exception_err'
<BR>/home/hys545/qemu/target-mips/exec.h:157: error: previous declaration of 'do_raise_exception_err' was here
<BR>/home/hys545/qemu/target-mips/op_helper.c:45: error: conflicting types for 'do_raise_exception'
<BR>/home/hys545/qemu/target-mips/exec.h:159: error: previous declaration of 'do_raise_exception' was here
<BR>/home/hys545/qemu/target-mips/op_helper.c:45: error: conflicting types for 'do_raise_exception'
<BR>/home/hys545/qemu/target-mips/exec.h:159: error: previous declaration of 'do_raise_exception' was here
<BR>/home/hys545/qemu/target-mips/op_helper.c:119: error: conflicting types for 'do_mfc0'
<BR>/home/hys545/qemu/target-mips/exec.h:127: error: previous declaration of 'do_mfc0' was here
<BR>/home/hys545/qemu/target-mips/op_helper.c:119: error: conflicting types for 'do_mfc0'
<BR>/home/hys545/qemu/target-mips/exec.h:127: error: previous declaration of 'do_mfc0' was here
<BR>/home/hys545/qemu/target-mips/op_helper.c:268: error: conflicting types for 'do_mtc0'
<BR>/home/hys545/qemu/target-mips/exec.h:129: error: previous declaration of 'do_mtc0' was here
<BR>/home/hys545/qemu/target-mips/op_helper.c:268: error: conflicting types for 'do_mtc0'
<BR>/home/hys545/qemu/target-mips/exec.h:129: error: previous declaration of 'do_mtc0' was here
<BR>/home/hys545/qemu/target-mips/op_helper.c:607: error: conflicting types for 'do_pmon'
<BR>/home/hys545/qemu/target-mips/exec.h:149: error: previous declaration of 'do_pmon' was here
<BR>/home/hys545/qemu/target-mips/op_helper.c:607: error: conflicting types for 'do_pmon'
<BR>/home/hys545/qemu/target-mips/exec.h:149: error: previous declaration of 'do_pmon' was here
<BR>make[1]: *** [op_helper.o] 오류 1
<BR>
<BR>My step is
<BR>cvs update-2005-7-6
<BR>./configure
<BR>make
<BR>
<BR></BODY>
</HTML>

<BR>
<LINK href=http://www.dreamwiz.com/css/wd.css rel=STYLESHEET title="text spacing" type=text/css>
<table  border="0" cellspacing="0" cellpadding="0">
	<tr>
		<td>
			<table  border="0" cellspacing="0" cellpadding="0">
			<tr>
				<td align=left colspan=2>
				<!--@@@@ 개인 이미지관련 셋팅 START@@@@-->


<!--@@@@ 개인주소 스킨형태 START@@@@-->
<!---------------------------------->
	<!----------	스킨 2 START    -------->
	<!---------------------------------->
	<table width="225" border="0" cellspacing="0" cellpadding="0" background="http://address.dreamwiz.com/IMG/photo_img/h/y/hys545/p_hys545_SKIN">
	<tr><td style='padding:1 1 1 1' align="center">
	<table width="200" border="0" cellspacing="0" cellpadding="0">
	<tr height="10"><td></td></tr>
	<tr><td height="19" style="font-size: 11pt;  font-weight:bold;">황윤성</td></tr>
	<tr height="7"><td></td></tr>
	<tr><td>
	<table width="200" border="0" cellspacing="0" cellpadding="0">
	<tr height="14">
	<td >1980/10/28()</td></tr>
	</table>
	</td></tr>
	<tr height="8"><td></td></tr>
	<tr><td>
	<table width="200" border="0" cellspacing="0" cellpadding="0">
	<tr height="14">
	<td width="42" >426-811</td>
	<td width="4">
	<td width="154" >815-19 301호</td>
	</tr>
	</table>
	</td></tr>
	<tr height="3"><td></td></tr>
	<tr><td>
	<table width="200" border="0" cellspacing="0" cellpadding="0">
	<tr height="14"><td ></td></tr>
	<tr height="4"><td></td></tr>
	<tr height="19"><td  style="padding:0 0 0 0" class="f9 orange"><a href="http://mail.dreamwiz.com/AUTH/mail.cgi?c=W&to=hys545@dreamwiz.com" target=_blank class="ca_a2">hys545@dreamwiz.com</a></td></td>
	<tr height="1"><td></td></tr>
	<tr height="14"><td class="blue"><a href="http://" target=_blank class="b_q"></a></td></tr>
	</table>
	</td></tr>
	<tr><td height="7"></td></tr>
	<tr><td>
	<table width="200" border="0" cellspacing="0" cellpadding="0">
	<tr>
	<td width="117" height="47"></td>
	<td width="83" rowspan="3" style="padding:0 0 1 0">
	<table width="83" border="0" cellspacing="0" cellpadding="0">
	<tr><td height="83" align="right" valign="bottom"></td></tr>
	</table>
	</td></tr>
	<tr height="17"><td  style="padding:3 0 0 0"></td></tr>
	<tr height="19"><td  style="padding:4 0 0 0">H.P : 016-469-7702</td></tr>
	<tr><td height="10"></td></tr>
	</table>
	</td></tr>
	</table>
	</td></tr>
	</table>


				</td>
			</tr>
			</table>
		</td>
		</tr>
</table>
<table border="0" cellspacing="0" cellpadding="0"><tr><td height="5"></td></tr></table>
<table  border="0" cellspacing="0" cellpadding="0">
	<tr><td>
	<A HREF="http://www.dreamwiz.com/wd/add/ev/addcard_pr.htm" target=_blank><img src="http://i.dreamwiz.com/img/wd/add/ma_card.gif" border=0></A>
	</td>
	</tr>
</table>


<BR>
<a HREF="http://www.dreamwiz.com/" TARGET=_blank><img src=http://i.dreamwiz.com/img/wd/ma/m_dw_logo.gif WIDTH=223 HEIGHT=23 BORDER=0 style=margin-bottom:-5;></a> <span style="font-size: 9pt; font-family:gulim,Arial; color: #494949; text-decoration: none;">http://www.dreamwiz.com/</span><br>
<img src="http://i.dreamwiz.com/dw/ko/n.gif" width=1 height=3 border="0"><br><a href="http://ebiz.dreamwiz.com/BIN/pl.cgi?page=mailcontent&save=100&http://asz.dreamwiz.com" target="_blank"><img src="http://i.dreamwiz.com/img/wd/ma/m_pcv.gif" width="279" height="27" align="absmiddle" border="0"></a>
<img src="http://i.dreamwiz.com/dw/ko/n.gif" width=5 height=1 border="0"><a href="http://www.dreamwiz.com/dm/disk/dm_disk.htm" target="_blank"><img src="http://i.dreamwiz.com/img/wd/ma/m_disk.gif" width=248 height=27 align="absmiddle" border="0"></a>


<IMG SRC="http://mailchk.dreamwiz.com/cgi-bin/receive_check.cgi?sender=hys545@dreamwiz.com&msgid=%3C20050706084045.0001622201F201FF@mail6.dreamwiz.com%3E&receiver=qemu-devel@nongnu.org&key=e41bdabb4ed953f5dcb1fab3ff367ffc" WIDTH="1" HEIGHT="1" BORDER="0">

                                                             

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2012-11-01 21:29 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-16 16:25 [Qemu-devel] Compile error Gerhard Wiesinger
2012-10-10  5:17 ` Gerhard Wiesinger
2012-10-10  5:52   ` [Qemu-devel] Wrong license (GPL 2 only) for files in fsdev Stefan Weil
2012-10-10  7:14     ` Paolo Bonzini
2012-11-01 19:47   ` [Qemu-devel] Compile error Gerhard Wiesinger
2012-11-01 20:13     ` Max Filippov
2012-11-01 20:27       ` Gerhard Wiesinger
2012-11-01 20:58     ` Anthony Liguori
2012-11-01 21:29       ` Gerhard Wiesinger
  -- strict thread matches above, loose matches on Subject: below --
2011-11-02 21:22 [Qemu-devel] Do you have a use for a tester of virtio-scsi with CD drives ? Thomas Schmitt
2011-11-02 22:08 ` Thomas Schmitt
2011-11-02 22:16   ` [Qemu-devel] Compile error Frans de Boer
2011-11-02 22:19     ` Anthony Liguori
2011-11-02 22:31       ` Frans de Boer
2005-07-06  8:40 [Qemu-devel] compile error 황윤성
2005-07-06  9:22 ` Hetz Ben Hamo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).