From: Stefan Weil <sw@weilnetz.de>
To: Mike Frysinger <vapier@gentoo.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] ignore more generated files
Date: Mon, 17 Sep 2012 07:31:12 +0200 [thread overview]
Message-ID: <5056B5A0.3060806@weilnetz.de> (raw)
In-Reply-To: <201209161655.23644.vapier@gentoo.org>
Am 16.09.2012 22:55, schrieb Mike Frysinger:
> On Sunday 16 September 2012 16:33:15 Stefan Weil wrote:
>> Am 16.09.2012 22:11, schrieb Mike Frysinger:
>>> +libcacard/vscclient
>>> +a.out*
>>> +.gdb_history
>>> +core
>>> +gmon.out
>>> +*.diff
>>> +*.patch
>>> +*.rej
>> IMHO .gitignore should only contain files which are generated
>> by a normal QEMU build.
>>
>> a.out*, .gdb_history, core, *.diff, *patch, *.rej are not QEMU specific
>> and should be ignored in the user's GIT configuration.
> these files show up a lot when doing development on qemu, hence i think they do
> make sense to be listed here. it also makes things "just work" for all users
> rather than requiring every one to set up their local system in the same way.
> plus, that would conflict with repos that do want to merge these types of files
> (uncommon, but not unheard of as test inputs).
>
> it's not like entries in this file "cost" anything at all.
> -mike
Yes, these files show up when doing development, but not only on
QEMU. They are not at all QEMU specific. I assume that most developers
also have other projects which they work on, so IMHO ignoring those
files in their user settings makes more sense.
I personally would prefer to see *.rej files. Your patch ignores
them (which is not what I want). Therefore the claim
that those entries make thinks "just work" for all users is not true:
it's at least all users minus one.
See more in a previous mail on the same subject:
http://lists.gnu.org/archive/html/qemu-devel/2011-02/msg03017.html
(there was also another discussion thread which I did not find
any more).
You can also have a look at other project's .gitignore.
Linux' .gitignore for example looks much better than QEMU's.
It has comments (good!) and only very few entries which are not
generated files.
- Stefan
next prev parent reply other threads:[~2012-09-17 5:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-16 20:11 [Qemu-devel] [PATCH] ignore more generated files Mike Frysinger
2012-09-16 20:33 ` Stefan Weil
2012-09-16 20:55 ` Mike Frysinger
2012-09-17 5:31 ` Stefan Weil [this message]
2012-09-17 14:48 ` Eric Blake
2012-09-17 7:19 ` Jan Kiszka
2012-09-17 18:32 ` Mike Frysinger
2012-09-17 18:37 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5056B5A0.3060806@weilnetz.de \
--to=sw@weilnetz.de \
--cc=qemu-devel@nongnu.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).