From: Jan Kiszka <jan.kiszka@web.de>
To: Mike Frysinger <vapier@gentoo.org>
Cc: Stefan Weil <sw@weilnetz.de>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] ignore more generated files
Date: Mon, 17 Sep 2012 09:19:54 +0200 [thread overview]
Message-ID: <5056CF1A.5000702@web.de> (raw)
In-Reply-To: <201209161655.23644.vapier@gentoo.org>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 2012-09-16 22:55, Mike Frysinger wrote:
> On Sunday 16 September 2012 16:33:15 Stefan Weil wrote:
>> Am 16.09.2012 22:11, schrieb Mike Frysinger:
>>> +libcacard/vscclient +a.out* +.gdb_history +core +gmon.out
>>> +*.diff +*.patch +*.rej
>>
>> IMHO .gitignore should only contain files which are generated by
>> a normal QEMU build.
>>
>> a.out*, .gdb_history, core, *.diff, *patch, *.rej are not QEMU
>> specific and should be ignored in the user's GIT configuration.
>
> these files show up a lot when doing development on qemu, hence i
> think they do make sense to be listed here. it also makes things
> "just work" for all users rather than requiring every one to set
> up their local system in the same way. plus, that would conflict
> with repos that do want to merge these types of files (uncommon,
> but not unheard of as test inputs).
>
> it's not like entries in this file "cost" anything at all.
NAK. I'd like to see what is polluting my repositories, not ignoring
it because that's the policy of someone else. Excluding *.rej is
something I would _never_ do. If they lie around somewhere, something
was not merged here - that's my policy.
You are free to set your own core.excludefile. So please do not spread
this to generic .gitignores.
Jan
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://www.enigmail.net/
iEYEARECAAYFAlBWzxoACgkQitSsb3rl5xQk5ACgoRORiSgWkWlhkz4YdE2zQ1ZB
moUAoK8D5khm+Tz9QrcvKoAhpHOmz5pA
=FgFo
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2012-09-17 7:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-16 20:11 [Qemu-devel] [PATCH] ignore more generated files Mike Frysinger
2012-09-16 20:33 ` Stefan Weil
2012-09-16 20:55 ` Mike Frysinger
2012-09-17 5:31 ` Stefan Weil
2012-09-17 14:48 ` Eric Blake
2012-09-17 7:19 ` Jan Kiszka [this message]
2012-09-17 18:32 ` Mike Frysinger
2012-09-17 18:37 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5056CF1A.5000702@web.de \
--to=jan.kiszka@web.de \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).