qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] allow make {dist, }clean work w/out configure
Date: Mon, 17 Sep 2012 09:55:08 +0200	[thread overview]
Message-ID: <5056D75C.5070401@redhat.com> (raw)
In-Reply-To: <201209161603.24009.vapier@gentoo.org>

Il 16/09/2012 22:03, Mike Frysinger ha scritto:
>>> > > +ifeq ($(findstring clean,$(MAKECMDGOALS)),)
>> > 
>> > Please use instead:
>> > 
>> > ifneq ($(filter-out %clean,$(MAKECMDGOALS)),)
>> > 
>> > so that "make clean all" still gives error.
> that breaks `make` though.  or rather, `make` no longer errors out.  need to 
> make it a little more complicated to handle this.

Perhaps

MAKECMDGOALS ?= all

does it?

Paolo

  reply	other threads:[~2012-09-17  8:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-16  0:30 [Qemu-devel] [PATCH] allow make {dist,}clean work w/out configure Mike Frysinger
2012-09-16  9:52 ` [Qemu-devel] [PATCH] allow make {dist, }clean " Paolo Bonzini
2012-09-16 20:03   ` Mike Frysinger
2012-09-17  7:55     ` Paolo Bonzini [this message]
2012-09-16 20:07   ` [Qemu-devel] [PATCH v2] " Mike Frysinger
2012-09-17  8:46     ` Paolo Bonzini
2012-10-19 19:32     ` Aurelien Jarno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5056D75C.5070401@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).