From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56517) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TDXSq-0000Nb-Bd for qemu-devel@nongnu.org; Mon, 17 Sep 2012 05:18:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TDXSk-0006S8-Im for qemu-devel@nongnu.org; Mon, 17 Sep 2012 05:18:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46498) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TDXSk-0006Rw-B0 for qemu-devel@nongnu.org; Mon, 17 Sep 2012 05:17:54 -0400 Message-ID: <5056EABF.3080902@redhat.com> Date: Mon, 17 Sep 2012 11:17:51 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1347671609-26498-1-git-send-email-ronniesahlberg@gmail.com> <1347671609-26498-2-git-send-email-ronniesahlberg@gmail.com> In-Reply-To: <1347671609-26498-2-git-send-email-ronniesahlberg@gmail.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] SCSI: Standard INQUIRY data should report HiSup flag as set. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ronnie Sahlberg Cc: qemu-devel@nongnu.org Il 15/09/2012 03:13, Ronnie Sahlberg ha scritto: > QEMU as far as I know only reports LUN numbers using the modes that > are described in SAM4. > As such, since all LUN numbers generated by the SCSI emulation in QEMU > follow SAM4, we should set the HiSup bit in the standard INQUIRY data > to indicate such. > > From SAM4: > 4.6.3 LUNs overview > All LUN formats described in this standard are hierarchical in > structure even when only a single level in that hierarchy is used. > The HISUP bit shall be set to one in the standard INQUIRY data > (see SPC-4) when any LUN format described in this standard is used. > Non-hierarchical formats are outside the scope of this standard. > > Signed-off-by: Ronnie Sahlberg > --- > hw/scsi-disk.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c > index 1585683..52bc062 100644 > --- a/hw/scsi-disk.c > +++ b/hw/scsi-disk.c > @@ -678,7 +678,7 @@ static int scsi_disk_emulate_inquiry(SCSIRequest *req, uint8_t *outbuf) > * is actually implemented, but we're good enough. > */ > outbuf[2] = 5; > - outbuf[3] = 2; /* Format 2 */ > + outbuf[3] = 2 | 0x10; /* Format 2, HiSup */ > > if (buflen > 36) { > outbuf[4] = buflen - 5; /* Additional Length = (Len - 1) - 4 */ > Applied to scsi-next branch, thanks. Paolo