From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60745) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TDbux-0004fO-EQ for qemu-devel@nongnu.org; Mon, 17 Sep 2012 10:03:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TDbut-0004o9-Cm for qemu-devel@nongnu.org; Mon, 17 Sep 2012 10:03:19 -0400 Message-ID: <50572D93.8010701@CloudSwitch.Com> Date: Mon, 17 Sep 2012 10:02:59 -0400 From: Don Slutz MIME-Version: 1.0 References: <1347890425-9696-1-git-send-email-Don@CloudSwitch.com> In-Reply-To: <1347890425-9696-1-git-send-email-Don@CloudSwitch.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] target-i386: Report on error during cpu_x86_register(). List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Don Slutz Cc: peter.maydell@linaro.org, ehabkost@redhat.com, kvm@vger.kernel.org, qemu-trivial@nongnu.org, mtosatti@redhat.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, avi@redhat.com, anthony@codemonkey.ws, imammedo@redhat.com, afaerber@suse.de On 09/17/12 10:00, Don Slutz wrote: > Send it to stderr before free of the details. > > Signed-off-by: Don Slutz > --- > v2: Change __FUNCTION__ to __func__ > > target-i386/cpu.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > index 57c064f..760cca4 100644 > --- a/target-i386/cpu.c > +++ b/target-i386/cpu.c > @@ -1352,6 +1352,7 @@ int cpu_x86_register(X86CPU *cpu, const char *cpu_model) > } > object_property_set_str(OBJECT(cpu), def->model_id, "model-id", &error); > if (error_is_set(&error)) { > + fprintf(stderr, "%s: %s\n", __func__, error_get_pretty(error)); > error_free(error); > return -1; > } I am having a lot of mistakes this morning. Please ignore this e-mail.