* [Qemu-devel] [PATCH v2] target-i386: Report on error during cpu_x86_register().
@ 2012-09-17 14:00 Don Slutz
2012-09-17 14:02 ` Don Slutz
0 siblings, 1 reply; 4+ messages in thread
From: Don Slutz @ 2012-09-17 14:00 UTC (permalink / raw)
To: qemu-devel, mtosatti, ehabkost, imammedo, avi, afaerber,
peter.maydell, kvm, anthony
Cc: qemu-trivial, Don Slutz
Send it to stderr before free of the details.
Signed-off-by: Don Slutz <Don@CloudSwitch.com>
---
v2: Change __FUNCTION__ to __func__
target-i386/cpu.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 57c064f..760cca4 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1352,6 +1352,7 @@ int cpu_x86_register(X86CPU *cpu, const char *cpu_model)
}
object_property_set_str(OBJECT(cpu), def->model_id, "model-id", &error);
if (error_is_set(&error)) {
+ fprintf(stderr, "%s: %s\n", __func__, error_get_pretty(error));
error_free(error);
return -1;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH v2] target-i386: Report on error during cpu_x86_register().
2012-09-17 14:00 [Qemu-devel] [PATCH v2] target-i386: Report on error during cpu_x86_register() Don Slutz
@ 2012-09-17 14:02 ` Don Slutz
0 siblings, 0 replies; 4+ messages in thread
From: Don Slutz @ 2012-09-17 14:02 UTC (permalink / raw)
To: Don Slutz
Cc: peter.maydell, ehabkost, kvm, qemu-trivial, mtosatti, qemu-devel,
blauwirbel, avi, anthony, imammedo, afaerber
On 09/17/12 10:00, Don Slutz wrote:
> Send it to stderr before free of the details.
>
> Signed-off-by: Don Slutz <Don@CloudSwitch.com>
> ---
> v2: Change __FUNCTION__ to __func__
>
> target-i386/cpu.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 57c064f..760cca4 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -1352,6 +1352,7 @@ int cpu_x86_register(X86CPU *cpu, const char *cpu_model)
> }
> object_property_set_str(OBJECT(cpu), def->model_id, "model-id", &error);
> if (error_is_set(&error)) {
> + fprintf(stderr, "%s: %s\n", __func__, error_get_pretty(error));
> error_free(error);
> return -1;
> }
I am having a lot of mistakes this morning. Please ignore this e-mail.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Qemu-devel] [PATCH] target-i386: Report on error during cpu_x86_register().
@ 2012-09-01 20:47 Don Slutz
2012-09-03 0:09 ` [Qemu-devel] [PATCH v2] " Don Slutz
0 siblings, 1 reply; 4+ messages in thread
From: Don Slutz @ 2012-09-01 20:47 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Don Slutz
Send it to stderr before free of the details.
Signed-off-by: Don Slutz <Don@CloudSwitch.com>
---
target-i386/cpu.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 57c064f..5c0fef1 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1352,6 +1352,7 @@ int cpu_x86_register(X86CPU *cpu, const char *cpu_model)
}
object_property_set_str(OBJECT(cpu), def->model_id, "model-id", &error);
if (error_is_set(&error)) {
+ fprintf(stderr, "%s: %s\n", __FUNCTION__, error_get_pretty(error));
error_free(error);
return -1;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [Qemu-devel] [PATCH v2] target-i386: Report on error during cpu_x86_register().
2012-09-01 20:47 [Qemu-devel] [PATCH] " Don Slutz
@ 2012-09-03 0:09 ` Don Slutz
2012-09-11 14:13 ` Don Slutz
0 siblings, 1 reply; 4+ messages in thread
From: Don Slutz @ 2012-09-03 0:09 UTC (permalink / raw)
To: qemu-devel, blauwirbel; +Cc: qemu-trivial, Don Slutz
Send it to stderr before free of the details.
Signed-off-by: Don Slutz <Don@CloudSwitch.com>
---
v2: Change __FUNCTION__ to __func__
target-i386/cpu.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 57c064f..760cca4 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1352,6 +1352,7 @@ int cpu_x86_register(X86CPU *cpu, const char *cpu_model)
}
object_property_set_str(OBJECT(cpu), def->model_id, "model-id", &error);
if (error_is_set(&error)) {
+ fprintf(stderr, "%s: %s\n", __func__, error_get_pretty(error));
error_free(error);
return -1;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH v2] target-i386: Report on error during cpu_x86_register().
2012-09-03 0:09 ` [Qemu-devel] [PATCH v2] " Don Slutz
@ 2012-09-11 14:13 ` Don Slutz
0 siblings, 0 replies; 4+ messages in thread
From: Don Slutz @ 2012-09-11 14:13 UTC (permalink / raw)
To: Don Slutz; +Cc: blauwirbel, qemu-trivial, qemu-devel
On 09/02/12 20:09, Don Slutz wrote:
> Send it to stderr before free of the details.
>
> Signed-off-by: Don Slutz <Don@CloudSwitch.com>
> ---
> v2: Change __FUNCTION__ to __func__
>
> target-i386/cpu.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 57c064f..760cca4 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -1352,6 +1352,7 @@ int cpu_x86_register(X86CPU *cpu, const char *cpu_model)
> }
> object_property_set_str(OBJECT(cpu), def->model_id, "model-id", &error);
> if (error_is_set(&error)) {
> + fprintf(stderr, "%s: %s\n", __func__, error_get_pretty(error));
> error_free(error);
> return -1;
> }
The (3) patch set in
http://lists.gnu.org/archive/html/qemu-devel/2012-09/msg01400.html
includes this change, and so this request is being withdrawn.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-09-17 14:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-17 14:00 [Qemu-devel] [PATCH v2] target-i386: Report on error during cpu_x86_register() Don Slutz
2012-09-17 14:02 ` Don Slutz
-- strict thread matches above, loose matches on Subject: below --
2012-09-01 20:47 [Qemu-devel] [PATCH] " Don Slutz
2012-09-03 0:09 ` [Qemu-devel] [PATCH v2] " Don Slutz
2012-09-11 14:13 ` Don Slutz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).