From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:56257)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <don@cloudswitch.com>) id 1TDcLt-0005lS-H1
	for qemu-devel@nongnu.org; Mon, 17 Sep 2012 10:31:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <don@cloudswitch.com>) id 1TDcLm-0007rK-Ln
	for qemu-devel@nongnu.org; Mon, 17 Sep 2012 10:31:09 -0400
Received: from hub021-nj-8.exch021.serverdata.net ([206.225.164.233]:12794)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <don@cloudswitch.com>) id 1TDcLm-0007rB-H4
	for qemu-devel@nongnu.org; Mon, 17 Sep 2012 10:31:02 -0400
Message-ID: <50573424.4050004@CloudSwitch.Com>
Date: Mon, 17 Sep 2012 10:31:00 -0400
From: Don Slutz <Don@CloudSwitch.Com>
MIME-Version: 1.0
References: <1346427000-9496-1-git-send-email-Don@CloudSwitch.com>
	<1346433623-12549-1-git-send-email-Don@CloudSwitch.com>
	<5040F3F6.7040805@siemens.com> <5047B4E3.9000204@CloudSwitch.Com>
In-Reply-To: <5047B4E3.9000204@CloudSwitch.Com>
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] PING Re:  [PATCH v2] hw: Add VMware's GETHZ command.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On 09/05/12 16:24, Don Slutz wrote:
> On 08/31/12 13:27, Jan Kiszka wrote:
>> On 2012-08-31 19:20, Don Slutz wrote:
>>> This is known is linux as VMWARE_PORT_CMD_GETHZ.
>>>
>>> Signed-off-by: Don Slutz <Don@CloudSwitch.com>
>>> ---
>>>   hw/vmport.c |   23 ++++++++++++++++++++++-
>>>   1 files changed, 22 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/hw/vmport.c b/hw/vmport.c
>>> index a4f52ee..e856255 100644
>>> --- a/hw/vmport.c
>>> +++ b/hw/vmport.c
>>> @@ -31,8 +31,9 @@
>>>     #define VMPORT_CMD_GETVERSION 0x0a
>>>   #define VMPORT_CMD_GETRAMSIZE 0x14
>>> +#define VMPORT_CMD_GETHZ      0x2d
>>>   -#define VMPORT_ENTRIES 0x2c
>>> +#define VMPORT_ENTRIES 0x2e
>>>   #define VMPORT_MAGIC   0x564D5868
>>>     typedef struct _VMPortState
>>> @@ -102,6 +103,25 @@ static uint32_t vmport_cmd_ram_size(void 
>>> *opaque, uint32_t addr)
>>>       return ram_size;
>>>   }
>>>   +static uint32_t vmport_cmd_get_hz(void *opaque, uint32_t addr)
>>> +{
>>> +    CPUX86State *env = cpu_single_env;
>>> +    uint64_t value;
>>> +    const uint32_t apicHz = 1000000000L;
>>> +
>>> +    value = (uint64_t)env->tsc_khz * 1000;
>>> +    if (value) {
>>> +        /* apic-frequency (bus speed) */
>>> +        env->regs[R_ECX] = apicHz;
>>> +        /* High part of tsc-frequency */
>>> +        env->regs[R_EBX] = (uint32_t)(value >> 32);
>>> +        /* Low part of tsc-frequency */
>>> +        return (uint32_t)value;
>>> +    } else {
>>> +        return env->regs[R_EAX];
>>> +    }
>>> +}
>>> +
>>>   /* vmmouse helpers */
>>>   void vmmouse_get_data(uint32_t *data)
>>>   {
>>> @@ -141,6 +161,7 @@ static int vmport_initfn(ISADevice *dev)
>>>       /* Register some generic port commands */
>>>       vmport_register(VMPORT_CMD_GETVERSION, vmport_cmd_get_version, 
>>> NULL);
>>>       vmport_register(VMPORT_CMD_GETRAMSIZE, vmport_cmd_ram_size, 
>>> NULL);
>>> +    vmport_register(VMPORT_CMD_GETHZ, vmport_cmd_get_hz, NULL);
>>>       return 0;
>>>   }
>>>
>> Reviewed-by: Jan Kiszka <jan.kiszka@siemens.com>
>>
> Any thing else I need to do to get this into 1.3?
>    -Don Slutz
>
Ping.
   -Don Slutz