From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:56011)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1TDdND-000664-3e
	for qemu-devel@nongnu.org; Mon, 17 Sep 2012 11:36:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1TDdNC-0002CA-5g
	for qemu-devel@nongnu.org; Mon, 17 Sep 2012 11:36:34 -0400
Received: from mail-qc0-f173.google.com ([209.85.216.173]:58050)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1TDdNC-0002Bn-1m
	for qemu-devel@nongnu.org; Mon, 17 Sep 2012 11:36:34 -0400
Received: by qcab12 with SMTP id b12so4859261qca.4
	for <qemu-devel@nongnu.org>; Mon, 17 Sep 2012 08:36:33 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <5057437F.9010503@twiddle.net>
Date: Mon, 17 Sep 2012 08:36:31 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1347836915-14091-1-git-send-email-aurelien@aurel32.net>
	<1347836915-14091-4-git-send-email-aurelien@aurel32.net>
In-Reply-To: <1347836915-14091-4-git-send-email-aurelien@aurel32.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/5] target-arm: convert shl and shr
 helpers to TCG
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org

On 09/16/2012 04:08 PM, Aurelien Jarno wrote:
> +    tcg_gen_setcondi_i32(TCG_COND_GE, tmp2, tmp1, 32); \
> +    tcg_gen_andi_i32(tmp1, tmp1, 0x1f);                \
> +    tcg_gen_##name##_i32(dest, t0, tmp1);              \
> +    tcg_temp_free_i32(tmp1);                           \
> +    tcg_gen_subi_i32(tmp2, tmp2, 1);                   \
> +    tcg_gen_and_i32(dest, dest, tmp2);                 \

Ought I revive my movcond patch?

Surely you can agree it's much more natural to write this
as a conditional move of zero than playing masking games.


r~