From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51307) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TDdoG-00058n-MK for qemu-devel@nongnu.org; Mon, 17 Sep 2012 12:04:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TDdoA-0002CQ-Ej for qemu-devel@nongnu.org; Mon, 17 Sep 2012 12:04:32 -0400 Received: from cantor2.suse.de ([195.135.220.15]:39944 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TDdoA-0002Bl-8E for qemu-devel@nongnu.org; Mon, 17 Sep 2012 12:04:26 -0400 Message-ID: <50574A07.5030009@suse.de> Date: Mon, 17 Sep 2012 18:04:23 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1347895732-22212-1-git-send-email-rth@twiddle.net> <1347895732-22212-5-git-send-email-rth@twiddle.net> In-Reply-To: <1347895732-22212-5-git-send-email-rth@twiddle.net> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 04/13] tcg-sparc: Assume v9 cpu always, i.e. force v8plus in 32-bit mode. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: blauwirbel@gmail.com, qemu-devel@nongnu.org Am 17.09.2012 17:28, schrieb Richard Henderson: > Current code doesn't actually work in 32-bit mode at all. Since > no one really noticed, drop the complication of v7 and v8 cpus. > Eliminate the --sparc_cpu configure option and standardize macro > testing on TCG_TARGET_REG_BITS / HOST_LONG_BITS >=20 > Also, a bug fix: don't MAP_FIXED right on top of the program > address space set in sparc64.ld. >=20 > Signed-off-by: Richard Henderson Without knowing the code, this does not strike me as the best of ideas: SPARC CPUs are rather uncommon these days, so being able to emulate it in sparc32-softmmu may be helpful for keeping it working. Could you elaborate on what exactly is broken and what would need to be done as alternative? The MAP_FIXED bugfix (keyword "also") should probably go into its own patch either way. Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg