From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38670) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TDepR-0001VY-05 for qemu-devel@nongnu.org; Mon, 17 Sep 2012 13:09:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TDepP-0005R6-9N for qemu-devel@nongnu.org; Mon, 17 Sep 2012 13:09:48 -0400 Received: from mail-bk0-f45.google.com ([209.85.214.45]:34555) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TDepP-0005Qn-2e for qemu-devel@nongnu.org; Mon, 17 Sep 2012 13:09:47 -0400 Received: by bkcji1 with SMTP id ji1so2207966bkc.4 for ; Mon, 17 Sep 2012 10:09:46 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <50575958.80306@redhat.com> Date: Mon, 17 Sep 2012 19:09:44 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1347897649-23236-1-git-send-email-pbonzini@redhat.com> <1347897649-23236-5-git-send-email-pbonzini@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 04/10] tcg: change cpu_restore_state to return void List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org Il 17/09/2012 19:06, Peter Maydell ha scritto: >> > The return value is used nowhere. > ...it looks like we should probably assert() rather than ploughing > blindly forward if we try to restore state to match a PC value and > it doesn't work for some reason. Couldn't that mean simply that the tb for instance wasn't mapped anywhere? That's the KVM case, at least. Paolo