From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41267) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TDf8B-0003li-Ah for qemu-devel@nongnu.org; Mon, 17 Sep 2012 13:29:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TDf85-0000Q6-HM for qemu-devel@nongnu.org; Mon, 17 Sep 2012 13:29:11 -0400 Received: from cantor2.suse.de ([195.135.220.15]:47039 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TDf85-0000Pn-7Y for qemu-devel@nongnu.org; Mon, 17 Sep 2012 13:29:05 -0400 Message-ID: <50575DDC.1090002@suse.de> Date: Mon, 17 Sep 2012 19:29:00 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1346877673-9136-1-git-send-email-ehabkost@redhat.com> In-Reply-To: <1346877673-9136-1-git-send-email-ehabkost@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/7] x86 CPU patches that didn't get into 1.2 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Peter Maydell , Don Slutz , qemu-devel@nongnu.org, Anthony Liguori , Igor Mammedov Hi Eduardo, Am 05.09.2012 22:41, schrieb Eduardo Habkost: > This is a small queue of patches that I consider "ready to go", that di= dn't > enter QEMU 1.2. >=20 > Eduardo Habkost (5): > i386: add missing CPUID_* constants > move CPU models from cpus-x86_64.conf to C > eliminate cpus-x86_64.conf file > x86_cpudef_setup: coding style change > i386: kill cpudef config section support >=20 > Peter Maydell (2): > target-i386: Fold -cpu ?cpuid, ?model output into -cpu help, drop > ?dump > Drop cpu_list_id macro Finished walking through these now and concur that they are ready to go! I've queued them on my qom-cpu branch (enforcing a consistent "target-i386" subject where applicable; dropping my pending field movements for now) and intend to send a pull shortly. https://github.com/afaerber/qemu-cpu/commits/qom-cpu To address Igor's setscalar() review comment, I appended this follow-up: diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 7c0953f..c2e65ea 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1393,18 +1393,6 @@ int cpu_x86_register(X86CPU *cpu, const char *cpu_model) #if !defined(CONFIG_USER_ONLY) -/* interpret radix and convert from string to arbitrary scalar, - * otherwise flag failure - */ -#define setscalar(pval, str, perr) \ -{ \ - char *pend; \ - unsigned long ul; \ - \ - ul =3D strtoul(str, &pend, 0); \ - *str && !*pend ? (*pval =3D ul) : (*perr =3D 1); \ -} - void cpu_clear_apic_feature(CPUX86State *env) { env->cpuid_features &=3D ~CPUID_APIC; Thanks for helping sort these things out, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg