From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC PATCH 04/10] tcg: change cpu_restore_state to return void
Date: Mon, 17 Sep 2012 20:25:55 +0200 [thread overview]
Message-ID: <50576B33.8090507@redhat.com> (raw)
In-Reply-To: <CAFEAcA8LDnk--WP-9HRON7iJBDvW=bKPP2TDf5vwHmKLUAtGvg@mail.gmail.com>
Il 17/09/2012 19:20, Peter Maydell ha scritto:
>> > Couldn't that mean simply that the tb for instance wasn't mapped
>> > anywhere? That's the KVM case, at least.
> Hmm. For TCG there are certainly some cases where failure to
> cpu_restore_state() means that the current CPU state is now broken;
> that should be fatal (and I'm not sure there are any cases where
> failure is OK. I think calls are generally protected by
> checking that tb_find_pc() returned non-NULL, so we shouldn't
> be trying to restore state unless we really were in the middle
> of a TB that we know about and can translate.)
>
> I'm not sure what the TB concept means for KVM -- after all KVM
> doesn't do any translation...
Nothing, but in some cases cpu_restore_state() is called from exception
handling helpers or something like that. My knowledge is spotty.
Paolo
next prev parent reply other threads:[~2012-09-17 18:26 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-17 16:00 [Qemu-devel] [RFC PATCH 00/10] Add --disable-tcg Paolo Bonzini
2012-09-17 16:00 ` [Qemu-devel] [RFC PATCH 01/10] configure: factor out list of supported Xen/KVM targets Paolo Bonzini
2012-09-17 17:02 ` Peter Maydell
2012-09-17 17:09 ` Paolo Bonzini
2012-09-17 17:13 ` Peter Maydell
2012-09-17 18:21 ` Stefano Stabellini
2012-09-17 18:30 ` Stefano Stabellini
2012-09-17 18:53 ` Stefano Stabellini
2012-09-17 19:15 ` Peter Maydell
2012-09-17 16:00 ` [Qemu-devel] [RFC PATCH 02/10] configure: add CONFIG_TCG=y to config-host.mak Paolo Bonzini
2012-09-17 16:00 ` [Qemu-devel] [RFC PATCH 03/10] vl: implement tcg_enabled() and tcg_available() as for other accelerators Paolo Bonzini
2012-09-17 16:00 ` [Qemu-devel] [RFC PATCH 04/10] tcg: change cpu_restore_state to return void Paolo Bonzini
2012-09-17 17:06 ` Peter Maydell
2012-09-17 17:09 ` Paolo Bonzini
2012-09-17 17:20 ` Peter Maydell
2012-09-17 18:25 ` Paolo Bonzini [this message]
2012-09-17 18:57 ` Peter Maydell
2012-09-17 16:00 ` [Qemu-devel] [RFC PATCH 05/10] exec: small adjustments for TCG separation Paolo Bonzini
2012-09-17 19:17 ` Blue Swirl
2012-09-17 21:47 ` Richard Henderson
2012-09-17 16:00 ` [Qemu-devel] [RFC PATCH 06/10] monitor: disable info jit if !TCG Paolo Bonzini
2012-09-17 16:00 ` [Qemu-devel] [RFC PATCH 07/10] configure: emit summary at the very end Paolo Bonzini
2012-09-17 16:00 ` [Qemu-devel] [RFC PATCH 08/10] configure: add --disable-tcg configure option Paolo Bonzini
2012-09-17 16:00 ` [Qemu-devel] [RFC PATCH 09/10] i386: move TCG functions out of helper.o, non-TCG functions to cpu.o Paolo Bonzini
2012-09-17 17:12 ` Peter Maydell
2012-09-17 18:39 ` Paolo Bonzini
2012-09-17 19:15 ` Blue Swirl
2012-09-17 16:00 ` [Qemu-devel] [RFC PATCH 10/10] build: do not build TCG files if TCG is disabled Paolo Bonzini
2012-09-17 19:20 ` [Qemu-devel] [RFC PATCH 00/10] Add --disable-tcg Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50576B33.8090507@redhat.com \
--to=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).