From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:55150)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TDgDy-0005mI-3c
	for qemu-devel@nongnu.org; Mon, 17 Sep 2012 14:39:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TDgDx-0002bQ-1j
	for qemu-devel@nongnu.org; Mon, 17 Sep 2012 14:39:14 -0400
Received: from mail-wi0-f181.google.com ([209.85.212.181]:61083)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TDgDw-0002bM-RS
	for qemu-devel@nongnu.org; Mon, 17 Sep 2012 14:39:12 -0400
Received: by wibhm2 with SMTP id hm2so2097976wib.10
	for <qemu-devel@nongnu.org>; Mon, 17 Sep 2012 11:39:12 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <50576E4D.2020606@redhat.com>
Date: Mon, 17 Sep 2012 20:39:09 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1347897649-23236-1-git-send-email-pbonzini@redhat.com>
	<1347897649-23236-10-git-send-email-pbonzini@redhat.com>
	<CAFEAcA_HAro_YORSstP=tnG392i-TKqqav=sqVAUevGVKOiUDw@mail.gmail.com>
In-Reply-To: <CAFEAcA_HAro_YORSstP=tnG392i-TKqqav=sqVAUevGVKOiUDw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH 09/10] i386: move TCG functions out of
 helper.o, non-TCG functions to cpu.o
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org

Il 17/09/2012 19:12, Peter Maydell ha scritto:
>> > +
>> > +    if (env->watchpoint_hit) {
>> > +        if (env->watchpoint_hit->flags & BP_CPU) {
>> > +            env->watchpoint_hit = NULL;
>> > +            if (check_hw_breakpoints(env, 0))
>> > +                raise_exception(env, EXCP01_DB);
>> > +            else
>> > +                cpu_resume_from_signal(env, NULL);
>> > +        }
>> > +    } else {
>> > +        QTAILQ_FOREACH(bp, &env->breakpoints, entry)
>> > +            if (bp->pc == env->eip) {
>> > +                if (bp->flags & BP_CPU) {
>> > +                    check_hw_breakpoints(env, 1);
>> > +                    raise_exception(env, EXCP01_DB);
>> > +                }
>> > +                break;
>> > +            }
>> > +    }
>> > +}
> Why does moving this from one helper.c file to another let us
> remove *helper.c from the non-TCG build?

It's *_helper.c, i.e. helper.c remains in the non-TCG build.  But this
function has a dependency on excp_helper.c, and is not used in the
non-TCG case, so move it where it belongs.

Paolo