From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34616) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TDhLk-00053G-5y for qemu-devel@nongnu.org; Mon, 17 Sep 2012 15:51:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TDhLi-0000Ef-5m for qemu-devel@nongnu.org; Mon, 17 Sep 2012 15:51:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51019) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TDhLh-0000EN-TX for qemu-devel@nongnu.org; Mon, 17 Sep 2012 15:51:18 -0400 Message-ID: <50577F2E.1080609@redhat.com> Date: Mon, 17 Sep 2012 13:51:10 -0600 From: Eric Blake MIME-Version: 1.0 References: <1342383972-11640-1-git-send-email-vapier@gentoo.org> <87sjagtp7n.fsf@codemonkey.ws> In-Reply-To: <87sjagtp7n.fsf@codemonkey.ws> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig42521D66CED1EFC0FCF77A97" Subject: Re: [Qemu-devel] [PATCH] configure: do not quote $PKG_CONFIG List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Mike Frysinger , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig42521D66CED1EFC0FCF77A97 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 09/17/2012 01:38 PM, Anthony Liguori wrote: > Mike Frysinger writes: >=20 >> We should not quote the PKG_CONFIG setting as this deviates from the >> canonical upstream behavior that gets integrated with all other build >> systems, and deviates from how we treat all other toolchain variables >> that we get from the environment. >> >> Ultimately, the point is that it breaks passing custom flags directly >> to pkg-config via the env var where this normally works elsewhere, >> and it used to work in the past. >> >> Signed-off-by: Mike Frysinger >=20 > This doesn't make any sense to me. What is the command line that > you're trying to execute? >=20 > This obviously would introduce a bug if there was a space in the > filename of the pkg-config binary. Except that the de facto standard is that the pkg-config binary already is prohibited from having a space in the filename. https://lists.gnu.org/archive/html/qemu-devel/2012-07/msg02015.html --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig42521D66CED1EFC0FCF77A97 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQV38wAAoJEKeha0olJ0NqINsIAKhmqqWCPgZifi5bXmg91mvV O8d+W3wRzUoW0B/iYR6isvi8bv8ZtBiB3MkDeeVtsh8nHay2xoJNEZ29fAMsI0bE UR5sheOjGdap4O4V0jdtk/6V+OJIJz9+iZAX8qETc6YcJDpPIYyWzDBUnYHtLTg8 YLPLH48qBRuAT9GZkKv7E2X+McQ8fAmguHqKmnDOxXOrz6C3MwqzgqDzKAlidXwe MEn0ehd00b10+VdQ/PsQ8sT6HnCRQXh8PiY56wfR2vO2tmn3Flbw/BsyZbzLQDJC oJrG/GdPQVvPRATAG6wre0oiJofA5IXdO5Xg0Hrx2YRGdoxLHMiSqClEvGb85JI= =bFBi -----END PGP SIGNATURE----- --------------enig42521D66CED1EFC0FCF77A97--