From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:42984)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1TDjA3-0004sn-FH
	for qemu-devel@nongnu.org; Mon, 17 Sep 2012 17:47:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1TDjA2-0002hS-IT
	for qemu-devel@nongnu.org; Mon, 17 Sep 2012 17:47:23 -0400
Received: from mail-qa0-f45.google.com ([209.85.216.45]:43901)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1TDjA2-0002gs-Bu
	for qemu-devel@nongnu.org; Mon, 17 Sep 2012 17:47:22 -0400
Received: by qadc10 with SMTP id c10so1925096qad.4
	for <qemu-devel@nongnu.org>; Mon, 17 Sep 2012 14:47:21 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <50579A67.7020204@twiddle.net>
Date: Mon, 17 Sep 2012 14:47:19 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1347897649-23236-1-git-send-email-pbonzini@redhat.com>
	<1347897649-23236-6-git-send-email-pbonzini@redhat.com>
	<CAAu8pHu4heEOQALo2_H-AVgZ53NbpBGBA=eR0gwgHX=HEfZR+w@mail.gmail.com>
In-Reply-To: <CAAu8pHu4heEOQALo2_H-AVgZ53NbpBGBA=eR0gwgHX=HEfZR+w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH 05/10] exec: small adjustments for TCG
 separation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org

On 09/17/2012 12:17 PM, Blue Swirl wrote:
>> > +void tcg_exec_init(unsigned long tb_size)
>> > +{
>> > +#ifndef CONFIG_TCG
>> > +    /* We cannot yet use tcg_enabled() here, it is set below.  */
>> > +    return;
> This leaves a lot of unreachable code after return, possibly
> introducing warnings and with low enough optimization level, maybe
> break linking. Please add #else and move #endif to end of the
> function.
> 

No, this really should work all the time.

Certainly gcc will not warn for unreachable code after return,
and will even at -O0 remove it.


r~