From: Jan Kiszka <jan.kiszka@web.de>
To: Stefan Weil <sw@weilnetz.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] xtensa: Fix broken build (linker error)
Date: Mon, 17 Sep 2012 23:55:09 +0200 [thread overview]
Message-ID: <50579C3D.7040005@web.de> (raw)
In-Reply-To: <1347912880-30161-1-git-send-email-sw@weilnetz.de>
[-- Attachment #1: Type: text/plain, Size: 1363 bytes --]
On 2012-09-17 22:14, Stefan Weil wrote:
> This configuration requires CONFIG_i8254:
>
> configure --target-list=xtensa-softmmu --audio-card-list=pcspk
This is wrong. The pcspk "audio card" is registered automatically for
those targets that support it.
>
> Reported-by: Vassili Karpov (malc) <av1474@comtv.ru>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> default-configs/xtensa-softmmu.mak | 1 +
> default-configs/xtensaeb-softmmu.mak | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/default-configs/xtensa-softmmu.mak b/default-configs/xtensa-softmmu.mak
> index 9d8899c..c3a263b 100644
> --- a/default-configs/xtensa-softmmu.mak
> +++ b/default-configs/xtensa-softmmu.mak
> @@ -1,5 +1,6 @@
> # Default configuration for Xtensa
>
> +CONFIG_I8254=y
And this wrong as well. xtensa does not include any speaker, nor does it
include a PIT.
Jan
> CONFIG_SERIAL=y
> CONFIG_OPENCORES_ETH=y
> CONFIG_PFLASH_CFI01=y
> diff --git a/default-configs/xtensaeb-softmmu.mak b/default-configs/xtensaeb-softmmu.mak
> index 9d8899c..c3a263b 100644
> --- a/default-configs/xtensaeb-softmmu.mak
> +++ b/default-configs/xtensaeb-softmmu.mak
> @@ -1,5 +1,6 @@
> # Default configuration for Xtensa
>
> +CONFIG_I8254=y
> CONFIG_SERIAL=y
> CONFIG_OPENCORES_ETH=y
> CONFIG_PFLASH_CFI01=y
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
next prev parent reply other threads:[~2012-09-17 21:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-17 20:14 [Qemu-devel] [PATCH] xtensa: Fix broken build (linker error) Stefan Weil
2012-09-17 21:55 ` Jan Kiszka [this message]
2012-09-17 22:08 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50579C3D.7040005@web.de \
--to=jan.kiszka@web.de \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).