* [Qemu-devel] [PATCH] xtensa: Fix broken build (linker error)
@ 2012-09-17 20:14 Stefan Weil
2012-09-17 21:55 ` Jan Kiszka
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Weil @ 2012-09-17 20:14 UTC (permalink / raw)
To: malc; +Cc: Stefan Weil, Anthony Liguori, qemu-devel
This configuration requires CONFIG_i8254:
configure --target-list=xtensa-softmmu --audio-card-list=pcspk
Reported-by: Vassili Karpov (malc) <av1474@comtv.ru>
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
default-configs/xtensa-softmmu.mak | 1 +
default-configs/xtensaeb-softmmu.mak | 1 +
2 files changed, 2 insertions(+)
diff --git a/default-configs/xtensa-softmmu.mak b/default-configs/xtensa-softmmu.mak
index 9d8899c..c3a263b 100644
--- a/default-configs/xtensa-softmmu.mak
+++ b/default-configs/xtensa-softmmu.mak
@@ -1,5 +1,6 @@
# Default configuration for Xtensa
+CONFIG_I8254=y
CONFIG_SERIAL=y
CONFIG_OPENCORES_ETH=y
CONFIG_PFLASH_CFI01=y
diff --git a/default-configs/xtensaeb-softmmu.mak b/default-configs/xtensaeb-softmmu.mak
index 9d8899c..c3a263b 100644
--- a/default-configs/xtensaeb-softmmu.mak
+++ b/default-configs/xtensaeb-softmmu.mak
@@ -1,5 +1,6 @@
# Default configuration for Xtensa
+CONFIG_I8254=y
CONFIG_SERIAL=y
CONFIG_OPENCORES_ETH=y
CONFIG_PFLASH_CFI01=y
--
1.7.10
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] xtensa: Fix broken build (linker error)
2012-09-17 20:14 [Qemu-devel] [PATCH] xtensa: Fix broken build (linker error) Stefan Weil
@ 2012-09-17 21:55 ` Jan Kiszka
2012-09-17 22:08 ` Anthony Liguori
0 siblings, 1 reply; 3+ messages in thread
From: Jan Kiszka @ 2012-09-17 21:55 UTC (permalink / raw)
To: Stefan Weil; +Cc: Anthony Liguori, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 1363 bytes --]
On 2012-09-17 22:14, Stefan Weil wrote:
> This configuration requires CONFIG_i8254:
>
> configure --target-list=xtensa-softmmu --audio-card-list=pcspk
This is wrong. The pcspk "audio card" is registered automatically for
those targets that support it.
>
> Reported-by: Vassili Karpov (malc) <av1474@comtv.ru>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> default-configs/xtensa-softmmu.mak | 1 +
> default-configs/xtensaeb-softmmu.mak | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/default-configs/xtensa-softmmu.mak b/default-configs/xtensa-softmmu.mak
> index 9d8899c..c3a263b 100644
> --- a/default-configs/xtensa-softmmu.mak
> +++ b/default-configs/xtensa-softmmu.mak
> @@ -1,5 +1,6 @@
> # Default configuration for Xtensa
>
> +CONFIG_I8254=y
And this wrong as well. xtensa does not include any speaker, nor does it
include a PIT.
Jan
> CONFIG_SERIAL=y
> CONFIG_OPENCORES_ETH=y
> CONFIG_PFLASH_CFI01=y
> diff --git a/default-configs/xtensaeb-softmmu.mak b/default-configs/xtensaeb-softmmu.mak
> index 9d8899c..c3a263b 100644
> --- a/default-configs/xtensaeb-softmmu.mak
> +++ b/default-configs/xtensaeb-softmmu.mak
> @@ -1,5 +1,6 @@
> # Default configuration for Xtensa
>
> +CONFIG_I8254=y
> CONFIG_SERIAL=y
> CONFIG_OPENCORES_ETH=y
> CONFIG_PFLASH_CFI01=y
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] xtensa: Fix broken build (linker error)
2012-09-17 21:55 ` Jan Kiszka
@ 2012-09-17 22:08 ` Anthony Liguori
0 siblings, 0 replies; 3+ messages in thread
From: Anthony Liguori @ 2012-09-17 22:08 UTC (permalink / raw)
To: Jan Kiszka, Stefan Weil; +Cc: qemu-devel
Jan Kiszka <jan.kiszka@web.de> writes:
> On 2012-09-17 22:14, Stefan Weil wrote:
>> This configuration requires CONFIG_i8254:
>>
>> configure --target-list=xtensa-softmmu --audio-card-list=pcspk
>
> This is wrong. The pcspk "audio card" is registered automatically for
> those targets that support it.
>
>>
>> Reported-by: Vassili Karpov (malc) <av1474@comtv.ru>
>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>> ---
>> default-configs/xtensa-softmmu.mak | 1 +
>> default-configs/xtensaeb-softmmu.mak | 1 +
>> 2 files changed, 2 insertions(+)
>>
>> diff --git a/default-configs/xtensa-softmmu.mak b/default-configs/xtensa-softmmu.mak
>> index 9d8899c..c3a263b 100644
>> --- a/default-configs/xtensa-softmmu.mak
>> +++ b/default-configs/xtensa-softmmu.mak
>> @@ -1,5 +1,6 @@
>> # Default configuration for Xtensa
>>
>> +CONFIG_I8254=y
>
> And this wrong as well. xtensa does not include any speaker, nor does it
> include a PIT.
I was looking for docs and couldn't find any that indicated it contained
a PIT either.
Regards,
Anthony Liguori
>
> Jan
>
>> CONFIG_SERIAL=y
>> CONFIG_OPENCORES_ETH=y
>> CONFIG_PFLASH_CFI01=y
>> diff --git a/default-configs/xtensaeb-softmmu.mak b/default-configs/xtensaeb-softmmu.mak
>> index 9d8899c..c3a263b 100644
>> --- a/default-configs/xtensaeb-softmmu.mak
>> +++ b/default-configs/xtensaeb-softmmu.mak
>> @@ -1,5 +1,6 @@
>> # Default configuration for Xtensa
>>
>> +CONFIG_I8254=y
>> CONFIG_SERIAL=y
>> CONFIG_OPENCORES_ETH=y
>> CONFIG_PFLASH_CFI01=y
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-09-17 22:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-17 20:14 [Qemu-devel] [PATCH] xtensa: Fix broken build (linker error) Stefan Weil
2012-09-17 21:55 ` Jan Kiszka
2012-09-17 22:08 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).