From: Evgeny Voevodin <e.voevodin@samsung.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: peter.maydell@linaro.org, kyungmin.park@samsung.com,
qemu-devel@nongnu.org, aliguori@us.ibm.com
Subject: Re: [Qemu-devel] [RFC v2 04/12] hw/qdev-properties.c: Add "transport" property.
Date: Tue, 18 Sep 2012 08:48:13 +0400 [thread overview]
Message-ID: <5057FD0D.7080004@samsung.com> (raw)
In-Reply-To: <50571AA0.4070503@redhat.com>
On 09/17/2012 04:42 PM, Paolo Bonzini wrote:
> Il 17/09/2012 12:00, Evgeny Voevodin ha scritto:
>> Virtio back-end devices can be plugged into both transports:
>> VIRTIO_PCI and VIRTIO_MMIO. In order to choose the desired
>> transport we have a property "transport" in every back-end
>> state struct. By specifying -device virtio-blk-pci user chooses
>> VIRTIO_PCI transport and "transport" property is set automatically.
>> But in order to provide full control to user we need to have
>> "transport" property available to be set through command line:
>>
>> -device virtio-pci,id=virtio-pci.0
>> -device virtio-blk,transport=virtio-pci.0,...
> What's the difference between this and "bus"? i.e.
>
> -device virtio-pci,id=virtio-pci-0
> -device virtio-blk,bus=virtio-pci-0.0,...
>
> Paolo
>
The difference is that with "transport" I used a linked list like, say,
bdrv_states in block.c.
It's much simpler then use buses. Also I was planning to use a <link>.
In this approach buses are used only to reflect hierarchy of devices in
emulator manager.
And yes, cover letter contains quite misleading information because
attach to transport
is based on a list of links, not on buses. Sorry, I forgot that when
wrote the cover.
--
Kind regards,
Evgeny Voevodin,
Technical Leader,
Mobile Group,
Samsung Moscow Research Center,
e-mail: e.voevodin@samsung.com
next prev parent reply other threads:[~2012-09-18 4:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-17 10:00 [Qemu-devel] [RFC v2 00/12] Virtio-mmio refactoring Evgeny Voevodin
2012-09-17 10:00 ` [Qemu-devel] [RFC v2 01/12] virtio: Add support for guest setting of queue size Evgeny Voevodin
2012-09-17 10:00 ` [Qemu-devel] [RFC v2 02/12] virtio: Support transports which can specify the vring alignment Evgeny Voevodin
2012-09-17 10:00 ` [Qemu-devel] [RFC v2 03/12] Virtio: Add transport bindings Evgeny Voevodin
2012-09-17 10:00 ` [Qemu-devel] [RFC v2 04/12] hw/qdev-properties.c: Add "transport" property Evgeny Voevodin
2012-09-17 12:42 ` Paolo Bonzini
2012-09-18 4:48 ` Evgeny Voevodin [this message]
2012-09-17 10:00 ` [Qemu-devel] [RFC v2 05/12] hw/pci.c: Make pci_add_option_rom global visible Evgeny Voevodin
2012-09-17 10:00 ` [Qemu-devel] [RFC v2 06/12] Add MMIO based virtio transport Evgeny Voevodin
2012-09-17 10:00 ` [Qemu-devel] [RFC v2 07/12] hw/virtio-serial-bus.c: Add virtio-serial device Evgeny Voevodin
2012-09-17 10:00 ` [Qemu-devel] [RFC v2 08/12] hw/virtio-balloon.c: Add virtio-balloon device Evgeny Voevodin
2012-09-17 10:00 ` [Qemu-devel] [RFC v2 09/12] hw/virtio-net.c: Add virtio-net device Evgeny Voevodin
2012-09-17 10:00 ` [Qemu-devel] [RFC v2 10/12] hw/virtio-blk.c: Add virtio-blk device Evgeny Voevodin
2012-09-17 10:00 ` [Qemu-devel] [RFC v2 11/12] hw/virtio-pci-new.c: Add VirtIOPCI device Evgeny Voevodin
2012-09-17 10:00 ` [Qemu-devel] [RFC v2 12/12] hw/exynos4210.c: Create two virtio-mmio transport instances Evgeny Voevodin
2012-09-27 17:31 ` [Qemu-devel] [RFC v2 00/12] Virtio-mmio refactoring KONRAD Frédéric
2012-09-28 3:37 ` Evgeny Voevodin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5057FD0D.7080004@samsung.com \
--to=e.voevodin@samsung.com \
--cc=aliguori@us.ibm.com \
--cc=kyungmin.park@samsung.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).