From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:50861)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TDulU-0001HN-Pc
	for qemu-devel@nongnu.org; Tue, 18 Sep 2012 06:10:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TDulQ-0005wS-9A
	for qemu-devel@nongnu.org; Tue, 18 Sep 2012 06:10:48 -0400
Received: from mx1.redhat.com ([209.132.183.28]:8893)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TDulQ-0005wK-0e
	for qemu-devel@nongnu.org; Tue, 18 Sep 2012 06:10:44 -0400
Message-ID: <50584888.3020906@redhat.com>
Date: Tue, 18 Sep 2012 12:10:16 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1347958919-30380-1-git-send-email-xiawenc@linux.vnet.ibm.com>
	<1347958919-30380-5-git-send-email-xiawenc@linux.vnet.ibm.com>
In-Reply-To: <1347958919-30380-5-git-send-email-xiawenc@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V3 4/5] libqblock test build system
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanha@gmail.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, eblake@redhat.com

Il 18/09/2012 11:01, Wenchao Xia ha scritto:
>   Created a new directory in tests, make chekc-libqblock will build an
> executable binrary, make clean will delete it.
> 
> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
> ---
>  .gitignore                       |    1 +
>  Makefile                         |    1 +
>  tests/Makefile                   |    3 +++
>  tests/libqblock/Makefile         |   32 ++++++++++++++++++++++++++++++++
>  tests/libqblock/libqblock-test.c |    4 ++++
>  5 files changed, 41 insertions(+), 0 deletions(-)
>  create mode 100644 tests/libqblock/Makefile
>  create mode 100644 tests/libqblock/libqblock-test.c
> 
> diff --git a/.gitignore b/.gitignore
> index 824c0d2..eccb637 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -95,3 +95,4 @@ cscope.*
>  tags
>  TAGS
>  *~
> +tests/libqblock/*.bin
> diff --git a/Makefile b/Makefile
> index b0b9b8d..de8ea17 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -238,6 +238,7 @@ clean:
>  	rm -rf qapi-generated
>  	rm -rf qga/qapi-generated
>  	$(MAKE) -C tests/tcg clean
> +	$(MAKE) -C tests/libqblock clean
>  	for d in $(ALL_SUBDIRS) $(QEMULIBS) libcacard libqblock; do \
>  	if test -d $$d; then $(MAKE) -C $$d $@ || exit 1; fi; \
>  	rm -f $$d/qemu-options.def; \
> diff --git a/tests/Makefile b/tests/Makefile
> index 26a67ce..69af1e2 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -148,4 +148,7 @@ check-unit: $(patsubst %,check-%, $(check-unit-y))
>  check-block: $(patsubst %,check-%, $(check-block-y))
>  check: check-unit check-qtest
>  
> +check-libqblock:
> +	$(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -C tests/libqblock V="$(V)" TARGET_DIR="$*/" check-libqblock,)

Please just put everything in tests/Makefile. "make check" should run it
if LIBTOOL is available.

> +libqblock-test.bin: $(libqblock-test-objs) $(libqblock-la-path)
> +	$(call quiet-command,$(LIBTOOL) --mode=link --quiet --tag=CC $(CC) -shared -rpath $(libdir) -o $@ $^,"  lt LINK $@")

.bin looks so MS-DOS. :)

Paolo