From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:55420)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1TDxDo-0001SV-RC
	for qemu-devel@nongnu.org; Tue, 18 Sep 2012 08:48:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1TDxDj-0005Tc-29
	for qemu-devel@nongnu.org; Tue, 18 Sep 2012 08:48:12 -0400
Received: from mx1.redhat.com ([209.132.183.28]:56240)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1TDxDi-0005TX-QH
	for qemu-devel@nongnu.org; Tue, 18 Sep 2012 08:48:06 -0400
Message-ID: <50586D7F.8060307@redhat.com>
Date: Tue, 18 Sep 2012 14:47:59 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <20120917152149.GB6879@in.ibm.com>
	<20120917152249.GC6879@in.ibm.com>
In-Reply-To: <20120917152249.GC6879@in.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v7 1/5] sockets: Make inet_parse() non
	static.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: bharata@linux.vnet.ibm.com
Cc: Anthony Liguori <aliguori@us.ibm.com>, Anand Avati <aavati@redhat.com>, Vijay Bellur <vbellur@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>, Amar Tumballi <amarts@redhat.com>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>, Blue Swirl <blauwirbel@gmail.com>, Avi Kivity <avi@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

Am 17.09.2012 17:22, schrieb Bharata B Rao:
> sockets: Make inet_parse() non static.
> 
> From: Bharata B Rao <bharata@linux.vnet.ibm.com>
> 
> Make inet_parse() non-static so that other subsystems like gluster
> can use it to parse inet addresses. As a pre-requisite, define and
> globalize the qemu_inet_opts.
> 
> Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
> ---
> 
>  Makefile.objs  |    2 +-
>  qemu-config.c  |   31 +++++++++++++++++++++++++++++++
>  qemu-sockets.c |   42 ++++++------------------------------------
>  qemu_socket.h  |    1 +
>  4 files changed, 39 insertions(+), 37 deletions(-)

Making the option list global sounds fine, but I don't think it should
be moved to qemu-config.c or added to vm_config_groups, which is
generally used for command line options and config file entries. At
least I can't imagine a command line option -inet would be very useful.

Kevin