From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44791) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TDxNW-0007pI-Ts for qemu-devel@nongnu.org; Tue, 18 Sep 2012 08:58:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TDxNQ-0001rm-VW for qemu-devel@nongnu.org; Tue, 18 Sep 2012 08:58:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62415) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TDxNQ-0001qG-Mu for qemu-devel@nongnu.org; Tue, 18 Sep 2012 08:58:08 -0400 Message-ID: <50586FD7.6080206@redhat.com> Date: Tue, 18 Sep 2012 14:57:59 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <20120917152149.GB6879@in.ibm.com> <20120917152249.GC6879@in.ibm.com> <50586D7F.8060307@redhat.com> In-Reply-To: <50586D7F.8060307@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v7 1/5] sockets: Make inet_parse() non static. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Anthony Liguori , Anand Avati , Vijay Bellur , Stefan Hajnoczi , Amar Tumballi , qemu-devel@nongnu.org, Markus Armbruster , Blue Swirl , Avi Kivity , bharata@linux.vnet.ibm.com Il 18/09/2012 14:47, Kevin Wolf ha scritto: >> > Makefile.objs | 2 +- >> > qemu-config.c | 31 +++++++++++++++++++++++++++++++ >> > qemu-sockets.c | 42 ++++++------------------------------------ >> > qemu_socket.h | 1 + >> > 4 files changed, 39 insertions(+), 37 deletions(-) > Making the option list global sounds fine, but I don't think it should > be moved to qemu-config.c or added to vm_config_groups, which is > generally used for command line options and config file entries. At > least I can't imagine a command line option -inet would be very useful. Yes. Also, I'll send a pull-request for http://patchwork.ozlabs.org/patch/180237/ soon, so you might as well take that patch. Paolo