From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35623) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TDyjE-0002w3-Vk for qemu-devel@nongnu.org; Tue, 18 Sep 2012 10:24:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TDyj8-0002PX-CB for qemu-devel@nongnu.org; Tue, 18 Sep 2012 10:24:44 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:34846) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TDyj8-0002Hy-74 for qemu-devel@nongnu.org; Tue, 18 Sep 2012 10:24:38 -0400 Received: by mail-pb0-f45.google.com with SMTP id rp12so94988pbb.4 for ; Tue, 18 Sep 2012 07:24:37 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <5058841F.8060101@redhat.com> Date: Tue, 18 Sep 2012 16:24:31 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1347968442-8860-1-git-send-email-kwolf@redhat.com> <1347968442-8860-10-git-send-email-kwolf@redhat.com> In-Reply-To: <1347968442-8860-10-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 09/16] qcow2: Move COW and L2 update into own coroutine List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org Il 18/09/2012 13:40, Kevin Wolf ha scritto: > + qemu_co_mutex_unlock(&s->lock); > + qemu_co_rwlock_rdlock(&s->l2meta_flush); Should this lock be taken in process_l2meta? It's a bit easier to follow. Paolo > + l2meta->is_written = true; > + co = qemu_coroutine_create(process_l2meta); > + qemu_coroutine_enter(co, &p);