* [Qemu-devel] [PATCH] make_device_config.sh: Fix target path in generated dependency file
@ 2012-06-07 16:23 Andreas Färber
2012-09-18 12:29 ` [Qemu-devel] [Qemu-stable] " Michael Tokarev
0 siblings, 1 reply; 5+ messages in thread
From: Andreas Färber @ 2012-06-07 16:23 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerhard Wiesinger, qemu-stable, Andreas Färber
config-devices.mak.d is included from Makefile.target, i.e. from inside
the *-softmmu/ directory. It included the directory path, so never
applied to the actual config-devices.mak. Symptoms were spurious
dependency issues with default-configs/pci.mak.
Fix by using `basename` to strip the directory path.
Reported-by: Gerhard Wiesinger <lists@wiesinger.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
Seems I forgot to send this out before 1.1...
scripts/make_device_config.sh | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/scripts/make_device_config.sh b/scripts/make_device_config.sh
index 5d14885..0778fe2 100644
--- a/scripts/make_device_config.sh
+++ b/scripts/make_device_config.sh
@@ -25,4 +25,4 @@ done
process_includes $src > $dest
cat $src $all_includes | grep -v '^include' > $dest
-echo "$1: $all_includes" > $dep
+echo "`basename $1`: $all_includes" > $dep
--
1.7.7
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [Qemu-stable] [PATCH] make_device_config.sh: Fix target path in generated dependency file
2012-06-07 16:23 [Qemu-devel] [PATCH] make_device_config.sh: Fix target path in generated dependency file Andreas Färber
@ 2012-09-18 12:29 ` Michael Tokarev
2012-09-18 14:32 ` Andreas Färber
0 siblings, 1 reply; 5+ messages in thread
From: Michael Tokarev @ 2012-09-18 12:29 UTC (permalink / raw)
To: Andreas Färber; +Cc: Gerhard Wiesinger, qemu-devel, qemu-stable
Has it been applied to anything? I don't think so.
Is it still needed?
Thanks,
/mjt
On 07.06.2012 20:23, Andreas Färber wrote:
> config-devices.mak.d is included from Makefile.target, i.e. from inside
> the *-softmmu/ directory. It included the directory path, so never
> applied to the actual config-devices.mak. Symptoms were spurious
> dependency issues with default-configs/pci.mak.
>
> Fix by using `basename` to strip the directory path.
>
> Reported-by: Gerhard Wiesinger <lists@wiesinger.com>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
> Seems I forgot to send this out before 1.1...
>
> scripts/make_device_config.sh | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/make_device_config.sh b/scripts/make_device_config.sh
> index 5d14885..0778fe2 100644
> --- a/scripts/make_device_config.sh
> +++ b/scripts/make_device_config.sh
> @@ -25,4 +25,4 @@ done
> process_includes $src > $dest
>
> cat $src $all_includes | grep -v '^include' > $dest
> -echo "$1: $all_includes" > $dep
> +echo "`basename $1`: $all_includes" > $dep
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [Qemu-stable] [PATCH] make_device_config.sh: Fix target path in generated dependency file
2012-09-18 12:29 ` [Qemu-devel] [Qemu-stable] " Michael Tokarev
@ 2012-09-18 14:32 ` Andreas Färber
2012-10-27 8:32 ` Michael Tokarev
0 siblings, 1 reply; 5+ messages in thread
From: Andreas Färber @ 2012-09-18 14:32 UTC (permalink / raw)
To: Michael Tokarev
Cc: Gerhard Wiesinger, Paolo Bonzini, qemu-devel, Anthony Liguori,
qemu-stable
Am 18.09.2012 14:29, schrieb Michael Tokarev:
> Has it been applied to anything? I don't think so.
> Is it still needed?
Not in qemu.git yet, still applicable AFAICT. CC'ing Paolo.
/-F
>
> Thanks,
>
> /mjt
>
> On 07.06.2012 20:23, Andreas Färber wrote:
>> config-devices.mak.d is included from Makefile.target, i.e. from inside
>> the *-softmmu/ directory. It included the directory path, so never
>> applied to the actual config-devices.mak. Symptoms were spurious
>> dependency issues with default-configs/pci.mak.
>>
>> Fix by using `basename` to strip the directory path.
>>
>> Reported-by: Gerhard Wiesinger <lists@wiesinger.com>
>> Signed-off-by: Andreas Färber <afaerber@suse.de>
>> ---
>> Seems I forgot to send this out before 1.1...
>>
>> scripts/make_device_config.sh | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/scripts/make_device_config.sh b/scripts/make_device_config.sh
>> index 5d14885..0778fe2 100644
>> --- a/scripts/make_device_config.sh
>> +++ b/scripts/make_device_config.sh
>> @@ -25,4 +25,4 @@ done
>> process_includes $src > $dest
>>
>> cat $src $all_includes | grep -v '^include' > $dest
>> -echo "$1: $all_includes" > $dep
>> +echo "`basename $1`: $all_includes" > $dep
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [Qemu-stable] [PATCH] make_device_config.sh: Fix target path in generated dependency file
2012-09-18 14:32 ` Andreas Färber
@ 2012-10-27 8:32 ` Michael Tokarev
2012-12-03 19:31 ` [Qemu-devel] [Qemu-stable] [PATCH 1.3] " mdroth
0 siblings, 1 reply; 5+ messages in thread
From: Michael Tokarev @ 2012-10-27 8:32 UTC (permalink / raw)
To: qemu-devel
Cc: Gerhard Wiesinger, Paolo Bonzini, Andreas Färber,
Anthony Liguori, qemu-stable
Ping?
/mjt
On 18.09.2012 18:32, Andreas Färber wrote:
> Am 18.09.2012 14:29, schrieb Michael Tokarev:
>> Has it been applied to anything? I don't think so.
>> Is it still needed?
>
> Not in qemu.git yet, still applicable AFAICT. CC'ing Paolo.
>
> /-F
>
>>
>> Thanks,
>>
>> /mjt
>>
>> On 07.06.2012 20:23, Andreas Färber wrote:
>>> config-devices.mak.d is included from Makefile.target, i.e. from inside
>>> the *-softmmu/ directory. It included the directory path, so never
>>> applied to the actual config-devices.mak. Symptoms were spurious
>>> dependency issues with default-configs/pci.mak.
>>>
>>> Fix by using `basename` to strip the directory path.
>>>
>>> Reported-by: Gerhard Wiesinger <lists@wiesinger.com>
>>> Signed-off-by: Andreas Färber <afaerber@suse.de>
>>> ---
>>> Seems I forgot to send this out before 1.1...
>>>
>>> scripts/make_device_config.sh | 2 +-
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/scripts/make_device_config.sh b/scripts/make_device_config.sh
>>> index 5d14885..0778fe2 100644
>>> --- a/scripts/make_device_config.sh
>>> +++ b/scripts/make_device_config.sh
>>> @@ -25,4 +25,4 @@ done
>>> process_includes $src > $dest
>>>
>>> cat $src $all_includes | grep -v '^include' > $dest
>>> -echo "$1: $all_includes" > $dep
>>> +echo "`basename $1`: $all_includes" > $dep
>>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [Qemu-stable] [PATCH 1.3] make_device_config.sh: Fix target path in generated dependency file
2012-10-27 8:32 ` Michael Tokarev
@ 2012-12-03 19:31 ` mdroth
0 siblings, 0 replies; 5+ messages in thread
From: mdroth @ 2012-12-03 19:31 UTC (permalink / raw)
To: Michael Tokarev
Cc: qemu-stable, qemu-devel, Anthony Liguori, Gerhard Wiesinger,
Paolo Bonzini, Andreas Färber
On Sat, Oct 27, 2012 at 12:32:28PM +0400, Michael Tokarev wrote:
> Ping?
Ping.
Fix still applicable for 1.3, also looking to pull it in for 1.2.2.
>
> /mjt
>
> On 18.09.2012 18:32, Andreas Färber wrote:
> > Am 18.09.2012 14:29, schrieb Michael Tokarev:
> >> Has it been applied to anything? I don't think so.
> >> Is it still needed?
> >
> > Not in qemu.git yet, still applicable AFAICT. CC'ing Paolo.
> >
> > /-F
> >
> >>
> >> Thanks,
> >>
> >> /mjt
> >>
> >> On 07.06.2012 20:23, Andreas Färber wrote:
> >>> config-devices.mak.d is included from Makefile.target, i.e. from inside
> >>> the *-softmmu/ directory. It included the directory path, so never
> >>> applied to the actual config-devices.mak. Symptoms were spurious
> >>> dependency issues with default-configs/pci.mak.
> >>>
> >>> Fix by using `basename` to strip the directory path.
> >>>
> >>> Reported-by: Gerhard Wiesinger <lists@wiesinger.com>
> >>> Signed-off-by: Andreas Färber <afaerber@suse.de>
> >>> ---
> >>> Seems I forgot to send this out before 1.1...
> >>>
> >>> scripts/make_device_config.sh | 2 +-
> >>> 1 files changed, 1 insertions(+), 1 deletions(-)
> >>>
> >>> diff --git a/scripts/make_device_config.sh b/scripts/make_device_config.sh
> >>> index 5d14885..0778fe2 100644
> >>> --- a/scripts/make_device_config.sh
> >>> +++ b/scripts/make_device_config.sh
> >>> @@ -25,4 +25,4 @@ done
> >>> process_includes $src > $dest
> >>>
> >>> cat $src $all_includes | grep -v '^include' > $dest
> >>> -echo "$1: $all_includes" > $dep
> >>> +echo "`basename $1`: $all_includes" > $dep
> >>
> >
> >
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-12-03 19:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-07 16:23 [Qemu-devel] [PATCH] make_device_config.sh: Fix target path in generated dependency file Andreas Färber
2012-09-18 12:29 ` [Qemu-devel] [Qemu-stable] " Michael Tokarev
2012-09-18 14:32 ` Andreas Färber
2012-10-27 8:32 ` Michael Tokarev
2012-12-03 19:31 ` [Qemu-devel] [Qemu-stable] [PATCH 1.3] " mdroth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).