From: "Andreas Färber" <afaerber@suse.de>
To: Peter Crosthwaite <peter.crosthwaite@petalogix.com>
Cc: edgar.iglesias@gmail.com, crwulff@gmail.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v1 5/6] xilinx: fix names of ethernet and dma links.
Date: Tue, 18 Sep 2012 17:02:54 +0200 [thread overview]
Message-ID: <50588D1E.9060603@suse.de> (raw)
In-Reply-To: <CAEgOgz41FhYAN2oCWNYPBwYdbzqJS3JWdQJA33KNPZZ-7Hw5Pw@mail.gmail.com>
Am 18.09.2012 01:36, schrieb Peter Crosthwaite:
> On Tue, Sep 18, 2012 at 1:13 AM, Andreas Färber <afaerber@suse.de> wrote:
>> Am 17.09.2012 10:47, schrieb Peter A. G. Crosthwaite:
>>> @@ -80,7 +81,8 @@ xilinx_axiethernetdma_init(DeviceState *dev, StreamSlave *peer,
>>> Error *errp = NULL;
>>>
>>> qdev_prop_set_uint32(dev, "freqhz", freqhz);
>>> - object_property_set_link(OBJECT(dev), OBJECT(peer), "tx_dev", &errp);
>>> + object_property_set_link(OBJECT(dev), OBJECT(peer), "axistream-connected",
>>> + &errp);
>>> assert_no_error(errp);
>>> qdev_init_nofail(dev);
>>>
>>
>> Indentation of &errp looks odd despite no tabs - intentional?
>>
>
> I have indented to the first multiple of 4 spaces after the function
> opening brace. Is there a prescribed way? Can it be added to
> CODING_STYLE and checkpatch if there is a particular recommended way?
The usual convention is to align with the opening brace (i.e., 3 spaces
less), or if the function name or string argument is too long I believe
one 4-spaces indent from the block.
Cheers,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-09-18 15:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-17 8:47 [Qemu-devel] [PATCH v1 0/6] Microblaze Patches Peter A. G. Crosthwaite
2012-09-17 8:47 ` [Qemu-devel] [PATCH v1 1/6] xilinx_timer: Removed comma in device name Peter A. G. Crosthwaite
2012-09-17 8:47 ` [Qemu-devel] [PATCH v1 2/6] xilinx_timer: Send dbg msgs to stderr not stdout Peter A. G. Crosthwaite
2012-09-17 8:47 ` [Qemu-devel] [PATCH v1 3/6] xilinx_timer: Fixed "frequency" prop name Peter A. G. Crosthwaite
2012-09-17 8:47 ` [Qemu-devel] [PATCH v1 4/6] xilinx.h: Error check when setting links Peter A. G. Crosthwaite
2012-09-17 8:47 ` [Qemu-devel] [PATCH v1 5/6] xilinx: fix names of ethernet and dma links Peter A. G. Crosthwaite
2012-09-17 15:13 ` Andreas Färber
2012-09-17 23:36 ` Peter Crosthwaite
2012-09-18 15:02 ` Andreas Färber [this message]
2012-09-17 8:47 ` [Qemu-devel] [PATCH v1 6/6] xilinx_timer: Fix a compile error if debug enabled Peter A. G. Crosthwaite
2012-09-19 17:53 ` [Qemu-devel] [PATCH v1 0/6] Microblaze Patches Edgar E. Iglesias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50588D1E.9060603@suse.de \
--to=afaerber@suse.de \
--cc=crwulff@gmail.com \
--cc=edgar.iglesias@gmail.com \
--cc=peter.crosthwaite@petalogix.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).