From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:46738)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TDzKR-0006Ny-R0
	for qemu-devel@nongnu.org; Tue, 18 Sep 2012 11:03:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TDzKE-0000TQ-0L
	for qemu-devel@nongnu.org; Tue, 18 Sep 2012 11:03:11 -0400
Received: from cantor2.suse.de ([195.135.220.15]:55127 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TDzKD-0000TB-QL
	for qemu-devel@nongnu.org; Tue, 18 Sep 2012 11:02:57 -0400
Message-ID: <50588D1E.9060603@suse.de>
Date: Tue, 18 Sep 2012 17:02:54 +0200
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <cover.1347871393.git.peter.crosthwaite@petalogix.com>
	<fcd4d4905dbd503f730625bde50c6ed3637a080b.1347871393.git.peter.crosthwaite@petalogix.com>
	<50573E28.2040608@suse.de>
	<CAEgOgz41FhYAN2oCWNYPBwYdbzqJS3JWdQJA33KNPZZ-7Hw5Pw@mail.gmail.com>
In-Reply-To: <CAEgOgz41FhYAN2oCWNYPBwYdbzqJS3JWdQJA33KNPZZ-7Hw5Pw@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v1 5/6] xilinx: fix names of ethernet and
 dma links.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <peter.crosthwaite@petalogix.com>
Cc: edgar.iglesias@gmail.com, crwulff@gmail.com, qemu-devel@nongnu.org

Am 18.09.2012 01:36, schrieb Peter Crosthwaite:
> On Tue, Sep 18, 2012 at 1:13 AM, Andreas F=E4rber <afaerber@suse.de> wr=
ote:
>> Am 17.09.2012 10:47, schrieb Peter A. G. Crosthwaite:
>>> @@ -80,7 +81,8 @@ xilinx_axiethernetdma_init(DeviceState *dev, Stream=
Slave *peer,
>>>      Error *errp =3D NULL;
>>>
>>>      qdev_prop_set_uint32(dev, "freqhz", freqhz);
>>> -    object_property_set_link(OBJECT(dev), OBJECT(peer), "tx_dev", &e=
rrp);
>>> +    object_property_set_link(OBJECT(dev), OBJECT(peer), "axistream-c=
onnected",
>>> +                                &errp);
>>>      assert_no_error(errp);
>>>      qdev_init_nofail(dev);
>>>
>>
>> Indentation of &errp looks odd despite no tabs - intentional?
>>
>=20
> I have indented to the first multiple of 4 spaces after the function
> opening brace. Is there a prescribed way? Can it be added to
> CODING_STYLE and checkpatch if there is a particular recommended way?

The usual convention is to align with the opening brace (i.e., 3 spaces
less), or if the function name or string argument is too long I believe
one 4-spaces indent from the block.

Cheers,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg